Skip tests without optional dependencies in lean CI#2196
Open
brownbaerchen wants to merge 1 commit intohelmholtz-analytics:mainfrom
Open
Skip tests without optional dependencies in lean CI#2196brownbaerchen wants to merge 1 commit intohelmholtz-analytics:mainfrom
brownbaerchen wants to merge 1 commit intohelmholtz-analytics:mainfrom
Conversation
mtar
reviewed
Mar 11, 2026
Collaborator
mtar
left a comment
mtar
left a comment
There was a problem hiding this comment.
Thank you. Here are some thoughts I have about this.
Comment on lines
22
to
32
| - name: Use Python | ||
| uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0 | ||
| with: | ||
| python-version: '3.14' | ||
| architecture: x64 | ||
|
|
||
| - name: Setup MPI | ||
| uses: mpi4py/setup-mpi@40c19a60792debf8ca403a3e6ee5f84c4e76555d # v1.2.1 | ||
| with: | ||
| mpi: openmpi | ||
|
|
Collaborator
There was a problem hiding this comment.
These steps are not necessary any longer without the test.
Collaborator
There was a problem hiding this comment.
The script should run after the lean CI.
| - '3.14' # Latest stable | ||
| mpi: [ 'openmpi' ] | ||
| install-options: [ '.', '.[hdf5,netcdf,pandas,zarr]' ] | ||
| install-options: [ '.[hdf5,netcdf,pandas,zarr,dev]' ] |
Collaborator
There was a problem hiding this comment.
While we don't need to test the all combinations without the optional dependencies, I still recommend a single one. In the past, we had to fix some bugs because a non-dependency was overlooked at some point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CI can be more lean! Afaik, when installing optional dependencies, we only run more tests than without. So there is no need to also run without optional dependencies in the lean CI in my opinion. This halves the number of jobs spawned by the lean CI.
On the other hand, I do think the lean CI should run the linter.
ReceivePR should not run any tests or linters in my opinion. The workflows should be as simple as possible.
Changes proposed: