Skip to content

Skip tests without optional dependencies in lean CI #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brownbaerchen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip tests without optional dependencies in lean CI #2196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/workflows/ReceivePR.yml
View file
Open in desktop
Copy link
Collaborator

@mtar mtar Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script should run after the lean CI.

Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,6 @@ jobs:
with:
mpi: openmpi

- name: Test
run: |
pip install .[dev]
pip install pytest
pre-commit run --all-files
pytest

- name: Save PR number
env:
PR_NUMBER: ${{ github.event.number }}
Expand Down
17 changes: 13 additions & 4 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ on:
- dependabot/**

jobs:
approved:
if: github.event.pull_request.draft == false
tests:
runs-on: ubuntu-latest
timeout-minutes: 120
strategy:
Expand All @@ -18,7 +17,7 @@ jobs:
- '3.11' # Oldest supported
- '3.14' # Latest stable
mpi: [ 'openmpi' ]
install-options: [ '.', '.[hdf5,netcdf,pandas,zarr]' ]
install-options: [ '.[hdf5,netcdf,pandas,zarr,dev]' ]
Copy link
Collaborator

@mtar mtar Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we don't need to test the all combinations without the optional dependencies, I still recommend a single one. In the past, we had to fix some bugs because a non-dependency was overlooked at some point.

pytorch-version:
- 'torch==2.3.1 torchvision==0.18.1 torchaudio==2.3.1' # Oldest supported
- 'torch==2.9.1 torchvision==0.24.1 torchaudio==2.9.1' # JSC Stage 2026
Expand Down Expand Up @@ -48,10 +47,20 @@ jobs:
python-version: ${{ matrix.py-version }}
architecture: x64

- name: Test
- name: Install heat and pytest
run: |
pip install pytest
pip install ${{ matrix.pytorch-version }} ${{ matrix.install-options }} --extra-index-url https://download.pytorch.org/whl/cpu

- name: Lint
run: |
pre-commit run --all-files

- name: Run serial tests
run: |
# use pytest -vv -x for debugging
pytest

- name: Run parallel tests
run: |
mpirun -n 4 pytest -vv
Loading