Stop deploying over SSH; publish the book as a build artifact#475
Merged
Conversation
The "Release the book and website" workflow has been failing on every
push to main. The book and website build fine, but the deploy step
("Copy book to downloads server") can't reach the host in SSH_HOST:
ssh: connect to host *** port 22: Network unreachable
rsync error: unexplained error (code 255)
That's an infrastructure issue (server down / moved / firewalled), not a
problem with the book. Mark both rsync deploy steps continue-on-error so
a temporarily unreachable downloads server no longer fails the whole
release - the book/website artifacts are still uploaded to GitHub.
Also bump the deprecated actions flagged in the run annotations:
- burnett01/rsync-deployments 7.0.2 -> v8 (inputs unchanged)
- actions/checkout v3 -> v4 (Node 20 is being forced to Node 24)
hendricius
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The downloads server that this workflow used to deploy to over SSH is gone, which had been failing the Release the book and website run on every push to
main. Instead of deploying from CI, this workflow now just builds and publishes the book as a GitHub artifact. Releases are made manually from the the-bread-code-downloads repo, which pulls the latest artifact and commits it (served at downloads.the-bread-code.io).How
rsync-to-SSH-server steps (book + website). They could only ever fail now that the server is unreachable.book/release/as thebooksartifact (theTheBreadCode-*PDFs and EPUBs), so the downloads repo's release script can copy the correctly-named files directly. Previously this uploaded the raw build outputs (book.pdf,book.log,book.epub).actions/checkoutv3→v4.The website is still uploaded as an artifact; it is no longer pushed anywhere from CI.
Follow-up
Once this is merged and
mainproduces a green run,make releasein the downloads repo will pull the freshbooksartifact. (Artifacts expire after ~90 days, so releases should be made from reasonably recent builds; the script also supports--localto publish from a localmake bake.)