Skip to content

[gen] Align diy filter handling for same-location Po edges#1787

Merged
ShaleXIONG merged 1 commit intoherd:masterfrom
ShaleXIONG:filter-rfi-powwr
Apr 25, 2026
Merged

[gen] Align diy filter handling for same-location Po edges#1787
ShaleXIONG merged 1 commit intoherd:masterfrom
ShaleXIONG:filter-rfi-powwr

Conversation

@ShaleXIONG
Copy link
Copy Markdown
Collaborator

Treat same-location Po edges consistently with their internal communication counterparts in the diy7 filter,

  • PosWR behaves the same as Rfi
  • PosRW behaves the same as Fri
  • PosWW behaves the same as Coi

We add filter-check in CI.

@ShaleXIONG ShaleXIONG requested a review from relokin April 10, 2026 11:35
@ShaleXIONG ShaleXIONG marked this pull request as draft April 10, 2026 11:43
@ShaleXIONG ShaleXIONG changed the title [gen] Align diy filter handling for same-location Po edges [WIP][gen] Align diy filter handling for same-location Po edges Apr 10, 2026
@ShaleXIONG ShaleXIONG changed the title [WIP][gen] Align diy filter handling for same-location Po edges [gen] Align diy filter handling for same-location Po edges Apr 10, 2026
@ShaleXIONG ShaleXIONG marked this pull request as ready for review April 10, 2026 13:06
@ShaleXIONG ShaleXIONG force-pushed the filter-rfi-powwr branch 2 times, most recently from 9233fe5 to e484930 Compare April 15, 2026 10:00
@ShaleXIONG ShaleXIONG force-pushed the filter-rfi-powwr branch 2 times, most recently from d53d19c to 00f2753 Compare April 24, 2026 06:44
Copy link
Copy Markdown
Member

@relokin relokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the two commits in one and make sure that they are rebased on top of master before you merge.

Treat same-location `Po` edges consistently with their internal
communication counterparts in the `diy7` filter,
- `PosWR` follows `Rfi`
- `PosRW` follows `Fri`
- `PosWW` follows `Coi`
Update CI due to `Pos**` aligns with internal communication edges.
@ShaleXIONG ShaleXIONG merged commit 220e6c1 into herd:master Apr 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants