refactor: apply lint formatting to scripts and hooks folders#3669
Merged
refactor: apply lint formatting to scripts and hooks folders#3669
Conversation
k80bowman
approved these changes
Apr 15, 2026
Renames files from underscore to hyphen naming: - scripts/postrelease/install_scripts.js → install-scripts.js - scripts/utils/_version.js → version.js This aligns with the project's file naming standards.
Applies ESLint formatting fixes to scripts and hooks folders: - Reorder imports to follow style guide (node: prefixed imports first, then external, then internal) - Use node: prefix for Node.js built-in modules (node:path, node:child_process, etc.) - Change from `import * as` to default imports where appropriate - Add proper error handling with try-catch blocks in postrelease scripts - Remove unnecessary semicolons and apply consistent formatting This brings the scripts and hooks folders in line with the shared ESLint configuration.
eablack
force-pushed
the
eb/lint-fixes-scripts-hooks
branch
from
c4d0af5 to
dfdec67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies ESLint formatting fixes to the
scripts/andsrc/hooks/folders, bringing them in line with the shared ESLint configuration. The changes are split into two commits for clarity: first, pure file renames to preserve git history, then the lint fixes themselves.Key changes:
install_scripts.js→install-scripts.js,_version.js→version.js)node:prefix for Node.js built-in modules (node:path,node:child_process, etc.)import * asto default imports where appropriateType of Change
Patch Updates (patch semver update)
Testing
Notes:
These are pure formatting and style changes with no functional modifications. The code behavior remains unchanged.
Steps: