Simplify resolve-version CLI by moving LTS defaults into binary#1620
Merged
colincasey merged 4 commits intomainfrom Apr 21, 2026
Merged
Simplify resolve-version CLI by moving LTS defaults into binary#1620colincasey merged 4 commits intomainfrom
colincasey merged 4 commits intomainfrom
Conversation
This was referenced Apr 17, 2026
edmorley
approved these changes
Apr 21, 2026
colincasey
force-pushed
the
simplified-resolve-version
branch
from
4e1fba9 to
84f63c6
Compare
colincasey
force-pushed
the
resolve-version-resolution-struct
branch
2 times, most recently
from
26b9163 to
fcb7175
Compare
colincasey
force-pushed
the
simplified-resolve-version
branch
from
84f63c6 to
2b9a2df
Compare
Remove hardcoded lts_major_version from shell scripts. The binary now handles version defaulting and LTS derivation internally. Shell reads 'default' and 'lts_version' from JSON output for logging and warnings.
…nternally The binary now accepts an empty node_version to mean 'use default LTS'. LTS major is derived by resolving RECOMMENDED_LTS_VERSION against the inventory. JSON output includes new 'default' and 'lts_version' fields.
colincasey
force-pushed
the
simplified-resolve-version
branch
from
2b9a2df to
da584cf
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lts_major_versionCLI argument — the binary derives LTS major by resolvingRECOMMENDED_LTS_VERSIONagainst the inventorynode_versionto mean "use default LTS" — no more shell-side defaultingdefaultandlts_versionfields to JSON output for shell script logging/warningslts_major_version="24"fromlib/binaries.shfail_bin_installto take one argumentThe binary now owns all version knowledge. The shell is a thin JSON consumer.
Replaces #1613 and #1616. Stacked on #1619.