Warn when deploying with End-of-Life Node.js versions#1621
Merged
colincasey merged 10 commits intomainfrom Apr 27, 2026
Merged
Conversation
colincasey
force-pushed
the
eol-warnings-v2
branch
from
81a5a84 to
dbdc4cb
Compare
This was referenced Apr 17, 2026
Closed
colincasey
force-pushed
the
simplified-resolve-version
branch
3 times, most recently
from
2b9a2df to
da584cf
Compare
colincasey
force-pushed
the
eol-warnings-v2
branch
5 times, most recently
from
a22f587 to
5d51e81
Compare
colincasey
force-pushed
the
eol-warnings-v2
branch
2 times, most recently
from
394a7c0 to
0672376
Compare
Move the EOL boolean from inline JSON serialization into the Resolution struct so tests verify actual production logic instead of re-deriving it.
…ersions Functional tests using EOL Node fixtures now produce stderr output from the EOL warning. Switch from assertCapturedSuccess (which requires empty stderr) to assertCapturedSuccessWithWarnings (which only checks exit code).
colincasey
force-pushed
the
eol-warnings-v2
branch
from
854d091 to
d9931ac
Compare
colincasey
force-pushed
the
eol-warnings-v2
branch
from
d9931ac to
abaee7e
Compare
schneems
approved these changes
Apr 24, 2026
Contributor
schneems
left a comment
schneems
left a comment
There was a problem hiding this comment.
No blockers, left some comments
Co-authored-by: Richard Schneeman <richard.schneeman+foo@gmail.com> Signed-off-by: Colin Casey <casey.colin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eolboolean field to resolve-version JSON output, checking if the resolved version's major is inSUPPORTED_NODEJS_VERSIONSoutput::warningwhen deploying with an unsupported Node.js versionnode_version_eolmetric viabuild_data::set_rawMatches the CNB buildpack behavior from heroku/buildpacks-nodejs#1353.