Skip to content

Conversation

@mars
Copy link
Member

@mars mars commented Sep 15, 2025

Fix for issue where setting Space references as an ID/UUID will cause churn in the config, triggering recreation of susceptible resources on every apply.

Changes heroku_space_inbound_ruleset and heroku_space_app_access to honor whatever space identifier is set by the configuration, either ID/UUID or name, instead of resetting it back to name.

@mars mars marked this pull request as ready for review September 15, 2025 16:06
@wchrisjohnson
Copy link
Contributor

@mars Inn light of #332, how do you feel about this in that context? Or is this just a first step toward getting to that eventual end?

@mars
Copy link
Member Author

mars commented Sep 15, 2025

@wchrisjohnson We can definitely go a step further from this, and enforce Spaces by ID using a similar breaking, major version migration as that #332 Apps by ID.

Given the urgency for some existing users, this fix should resolve the immediate problem without forcing a major version release and manual config migration steps for everyone.

@mars mars merged commit 178a3be into master Sep 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants