-
Notifications
You must be signed in to change notification settings - Fork 78
Honor whatever the space attribute is set as, ID/UUID or name.
#405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f794d7a
Honor whatever the `space` attribute is set as, ID/UUID or name.
mars 3d901c5
Honor another space attribute setting, as ID/UUID or name.
mars 239b093
Docs update to use Space by name references
mars e55cdea
Update arguments with Space name guidance.
mars File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,14 +24,14 @@ resource "heroku_space" "default" { | |
|
|
||
| // Give an existing team member create_apps permissions to the Private Space | ||
| resource "heroku_space_app_access" "member1" { | ||
| space = heroku_space.default.id | ||
| space = heroku_space.default.name | ||
| email = "[email protected]" | ||
| permissions = ["create_apps"] | ||
| } | ||
|
|
||
| // Remove all permissions from an existing team member | ||
| resource "heroku_space_app_access" "member2" { | ||
| space = heroku_space.default.id | ||
| space = heroku_space.default.name | ||
| email = "[email protected]" | ||
| permissions = [] | ||
| } | ||
|
|
@@ -41,7 +41,7 @@ resource "heroku_space_app_access" "member2" { | |
|
|
||
| The following arguments are supported: | ||
|
|
||
| * `space` - (Required) The ID of the Private Space. | ||
| * `space` - (Required) The name of the Private Space (ID/UUID is acceptable too, but must be used consistently). | ||
| * `email` - (Required) The email of the existing Heroku Team member. | ||
| * `permissions` - (Required) The permissions to grant the team member for the Private Space. | ||
| Currently `create_apps` is the only supported permission. If not provided the member will have no permissions to the space. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.