feat: storage box api changes

[lukasmetzner]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 87.75510% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.39%. Comparing base (20e0a5f) to head (97ff733).
⚠️ Report is 1 commits behind head on storage-boxes.

Files with missing lines	Patch %	Lines
hcloud/storage_box.go	0.00%	2 Missing and 1 partial ⚠️
hcloud/storage_box_subaccount.go	91.17%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@              Coverage Diff               @@
##           storage-boxes     #745   +/-   ##
==============================================
  Coverage          78.38%   78.39%           
==============================================
  Files                 59       59           
  Lines               5561     5600   +39     
==============================================
+ Hits                4359     4390   +31     
- Misses               912      917    +5     
- Partials             290      293    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[phm07]

I did a quick pass and everything looks good to me so far

[apricote]

This change feels backward. The fields in update requests will become optional for all three resources.

[lukasmetzner]

The pointer was orignally there, because the API allowed empty strings to be set as a Storage Box name. This won't be the case in the future and an empty name will be ignored.

I thought this makes it somewhat easier to the user, as a pointer is not required.

We have a mixed pattern in the codebase, so I was unsure what the best option is. Both are fine for me.

// StorageBoxUpdateRequest defines the schema of the request to update a Storage Box.
type StorageBoxUpdateRequest struct {
	Name   string             `json:"name,omitempty"`
        // ...
}

// NetworkUpdateRequest defines the schema of the request to update a network.
type NetworkUpdateRequest struct {
	Name                  string             `json:"name,omitempty"`
        // ...
}

type LoadBalancerUpdateRequest struct {
	Name   *string            `json:"name,omitempty"`
        // ...
}

[jooola]

I prefer without pointer, reduces the complexity.

[lukasmetzner]

@apricote I would go ahead and merge this now, to proceed with the other review points in the main PR. We can discuss this topic there again, if you want.

[jooola]

🤩

[jooola]

The changes look good, I have comments on the code that didn't change though.