sysgpu: fix vulkan find best allocator selecting smaller memory types#1445
Open
shailpatels wants to merge 1 commit intohexops:mainfrom
Open
sysgpu: fix vulkan find best allocator selecting smaller memory types#1445shailpatels wants to merge 1 commit intohexops:mainfrom
shailpatels wants to merge 1 commit intohexops:mainfrom
Conversation
Only taking a look at the bitflags for linear_map_readable caused memory indexes with a smaller heap space to be selected. Signed-off-by: Shail Patel <shailpatel67@gmail.com>
1 task
shailpatels
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the bulkan sysgpu find best allocator logic. When searching for a candidate memory type for
.linear_write_mappable, only the memory bitflags are considered, which if a memory type with a smaller heap size was later in the list it would always be selected over.Now the logic is updated if there is a best type already selected, the next candidate will only be considered if its heap size was strictly larger.
Similar logic has been applied for the
.linear_read_mappablewhere the host visible bit would always cause the candidate to be selected. That has been removed since the top level if statement already checks for that.in my case specifically, the last memory index was the GPU BAR region which is host visible but only has 256 MB heap space and was always getting selected causing the
OutOfDeviceMemoryerror when ignoring regions with 10 and 25 GB of space.here is an example of it working!
(and reproducing the bug)
fixes #1352