HHH-20003: add Spanner temp table exporter #11465
Open
+88
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beikov
approved these changes
Dec 18, 2025
Member
beikov
left a comment
beikov
left a comment
There was a problem hiding this comment.
LGTM. Any reason why you marked it as draft?
Also, does Spanner support insert/update/delete statements in the with clause like PostgreSQL also known as "modifiable CTEs"? If so, we could configure the Spanner dialect to use that strategy instead for multi-table mutations/inserts.
Contributor
Author
|
Spanner doesn't not support insert/update/delete statements in the with clause, so can't use CteStrategy |
olavloite
reviewed
Dec 18, 2025
hibernate-core/src/main/java/org/hibernate/dialect/temptable/SpannerTemporaryTableExporter.java
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/dialect/temptable/SpannerTemporaryTableExporter.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spanner doesn’t have support for local or global temp tables so we have use PersistentTempTable strategy for bulk operations .
SpannerTemporaryTableExporter syntax provided for create table is compatible for Spanner as spanner requires primary key declaration to be outside the column declarations .
this change provides SpannerTemporaryTableExporter which will be used by spanner for DDL of temp tables
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-20003