-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-20003: add Spanner temp table exporter #11465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rayudu3745
wants to merge
1
commit into
hibernate:main
Choose a base branch
from
rayudu3745:spanner-fixes-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+88
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
...ate-core/src/main/java/org/hibernate/dialect/temptable/SpannerTemporaryTableExporter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * Copyright Red Hat Inc. and Hibernate Authors | ||
| */ | ||
| package org.hibernate.dialect.temptable; | ||
|
|
||
| import org.hibernate.dialect.SpannerDialect; | ||
| import org.hibernate.engine.spi.SharedSessionContractImplementor; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.function.Function; | ||
|
|
||
| /** | ||
| * Spanner-specific exporter for temporary tables. | ||
| * Spanner requires PRIMARY KEY definitions to be outside the column definition list. | ||
| * * Syntax: CREATE TABLE Name (Col Type) PRIMARY KEY (Col) | ||
| */ | ||
| public class SpannerTemporaryTableExporter extends StandardTemporaryTableExporter { | ||
|
|
||
| private final SpannerDialect dialect; | ||
|
|
||
| public SpannerTemporaryTableExporter(SpannerDialect dialect) { | ||
| super( dialect ); | ||
| this.dialect = dialect; | ||
| } | ||
|
|
||
| @Override | ||
| public String getSqlCreateCommand(TemporaryTable temporaryTable) { | ||
| final StringBuilder buffer = new StringBuilder( dialect.getCreateTableString() ) | ||
| .append( ' ' ) | ||
| .append( temporaryTable.getQualifiedTableName() ) | ||
| .append( " (" ); | ||
| final List<String> primaryKeyColumnNames = new ArrayList<>(); | ||
| boolean first = true; | ||
| for ( TemporaryTableColumn column : temporaryTable.getColumnsForExport() ) { | ||
| if ( first ) { | ||
| first = false; | ||
| } | ||
| else { | ||
| buffer.append( ", " ); | ||
| } | ||
| buffer.append( column.getColumnName() ).append( ' ' ); | ||
| final String databaseTypeName = column.getSqlTypeDefinition(); | ||
| buffer.append( databaseTypeName ); | ||
| if ( !column.isNullable() ) { | ||
| buffer.append( " not null" ); | ||
| } | ||
| // Track PK | ||
| if ( column.isPrimaryKey() ) { | ||
| primaryKeyColumnNames.add( column.getColumnName() ); | ||
| } | ||
| } | ||
| buffer.append( ')' ); | ||
| // append primary key (outside the column declaration for Spanner) | ||
rayudu3745 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // primary key () is still needed even if there are no primary key columns | ||
| buffer.append( " primary key (" ); | ||
| if ( !primaryKeyColumnNames.isEmpty() ) { | ||
| buffer.append( String.join( ", ", primaryKeyColumnNames ) ); | ||
| } | ||
| buffer.append( ')' ); | ||
| return buffer.toString(); | ||
| } | ||
|
|
||
| @Override | ||
| public String getSqlTruncateCommand( | ||
| TemporaryTable temporaryTable, | ||
| Function<SharedSessionContractImplementor, String> sessionUidAccess, | ||
| SharedSessionContractImplementor session) { | ||
| if ( temporaryTable.getSessionUidColumn() != null ) { | ||
| return super.getSqlTruncateCommand( temporaryTable, sessionUidAccess, session ); | ||
| } | ||
| else { | ||
| return dialect.getTruncateTableStatement( temporaryTable.getQualifiedTableName() ); | ||
| } | ||
| } | ||
|
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.