Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust some status codes returned by API when delete operation fails #139

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Feb 20, 2025

Otherwise, when using Nacos as the storage and deleting an inexist resource, a 500 error will be returned.

@CH3CHO CH3CHO requested a review from johnlanni as a code owner February 20, 2025 03:14
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 2d5c3be into higress-group:main Feb 24, 2025
2 checks passed
@CH3CHO CH3CHO deleted the fix/delete-error-status-code branch February 24, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants