fix: reuse PLUGIN_REGISTRY for IMAGE_REPO construction

[johnlanni]

Problem

After #239, IMAGE_REPO and PLUGIN_REGISTRY are set independently, which means:

• Duplicate registry domain logic
• Potential inconsistency (could use different registries)
• Violates DRY principle

Solution

Reuse PLUGIN_REGISTRY when constructing IMAGE_REPO:

# Before (in resetEnv):
IMAGE_REPO="${IMAGE_REPO:-$DEFAULT_IMAGE_REPO}"
detectPluginRegistry
PLUGIN_REGISTRY="${PLUGIN_REGISTRY:-$DEFAULT_PLUGIN_REGISTRY}"

# After:
detectPluginRegistry
PLUGIN_REGISTRY="${PLUGIN_REGISTRY:-$DEFAULT_PLUGIN_REGISTRY}"

if [ -z "$IMAGE_REPO" ]; then
  IMAGE_REPO="${PLUGIN_REGISTRY}/higress/all-in-one"
fi

Changes

1. Reorder in resetEnv():

   • Detect PLUGIN_REGISTRY first
   • Then construct IMAGE_REPO from it

2. Conditional IMAGE_REPO construction:

   • If IMAGE_REPO explicitly set → use it (backward compatible)
   • If not set → build from PLUGIN_REGISTRY

Benefits

✅ Single source of truth - Registry domain only detected once
✅ Guaranteed consistency - Container image and plugins always use same registry
✅ DRY principle - No duplicate timezone → registry mapping logic
✅ Backward compatible - Users can still override IMAGE_REPO explicitly

Example Behavior

Auto-detection (typical):

./get-ai-gateway.sh start --non-interactive --dashscope-key sk-xxx
# Output:
# Auto-detected timezone: Asia/Singapore
# Selected plugin registry: higress-registry.ap-southeast-7.cr.aliyuncs.com
#
# Both will use: higress-registry.ap-southeast-7.cr.aliyuncs.com
# - IMAGE_REPO: higress-registry.ap-southeast-7.cr.aliyuncs.com/higress/all-in-one
# - PLUGIN_REGISTRY: higress-registry.ap-southeast-7.cr.aliyuncs.com

Explicit override (advanced):

IMAGE_REPO="custom-registry.example.com/my-higress:latest" \
  ./get-ai-gateway.sh start --non-interactive --dashscope-key sk-xxx
# IMAGE_REPO: custom-registry.example.com/my-higress:latest (user override)
# PLUGIN_REGISTRY: higress-registry.cn-hangzhou.cr.aliyuncs.com (auto-detected)

Partial override (typical):

PLUGIN_REGISTRY="higress-registry.us-west-1.cr.aliyuncs.com" \
  ./get-ai-gateway.sh start --non-interactive --dashscope-key sk-xxx
# IMAGE_REPO: higress-registry.us-west-1.cr.aliyuncs.com/higress/all-in-one (derived)
# PLUGIN_REGISTRY: higress-registry.us-west-1.cr.aliyuncs.com (user override)

Testing

• Script syntax validation (bash -n)
• IMAGE_REPO derived from PLUGIN_REGISTRY when not set
• Explicit IMAGE_REPO override still works
• Both variables use same registry domain in default case

Related

• Improves: feat: auto-select plugin registry based on timezone #239 (auto-select plugin registry)

[lingma-agents]

🔍 代码审查进行中

⏳ 正在审查

⏰️ 剩余时间：约需数分钟

🔄 分支流向: fix/reuse-plugin-registry-in-image-repo ➜ main

📦 提交: 审查当前PR从123aa03到ec22c83的提交。

---

📒 文件清单 （1 个文件）

📝 变更: 1 个文件

📝 变更文件:

• all-in-one/get-ai-gateway.sh

[lingma-agents]

CodeReview流程已终止