Don't start downloading when core is not active #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See holepunchto/corestore#86 for a corestore test illustrating the current behaviour. That test passes when using this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour doesn't interact well with corestore, because whenever a peer connects on a discovery key with you, this line is called:
https://github.com/holepunchto/corestore/blob/3ab2595c8313179bc98567dbe28389245ddca6e8/index.js#L345
Even though
active: falseis passed in when creating the core, whenthis.downloadingis true (which it always is initially) you still end up requesting a download from all the other peers you're connected with on that core, and they end up doing the same, so it propagates.Note: I'm not sure why
this.downloadinghad default true. This is a big behaviour change, so might break something. Fwiw, tests also pass when it's defaulted to false.