New package AdditiveClosuresForCAP

[TKuh]

Split from FreydCatgoriesForCAP.

[mohamed-barakat]

Could you please make the corresponding PR for PackageJanitor?

[mohamed-barakat]

Thank you very much. Could you please

1. on this branch pull --rebase CAP_project
2. pull --rebase PackageJanitor
3. apply PackageJanitor (it will delete the subsplit push for GroupsAsCategories)
4. Rebump version of ModulePresentationsForCAP
5. update this PR

[mohamed-barakat]

There is an error during simulating the release:

ERROR: HTML manual contains absolute paths

[TKuh]

There is an error during simulating the release:

ERROR: HTML manual contains absolute paths

Yes, but I can't figure out where these absolute paths come from. :/ On my machine, I also get absolute paths for CAP, and they do not seem to cause trouble?

[kamalsaleh]

For some reason, I can see in the action logs the following line:

makefile:136: target 'ci-test_AdditiveClosuresForCAP' does not exist

The same for other packages like AttributeCategoryForCAP. Maybe investigating that and comparing with old actions might solve the issue.

[TKuh]

For some reason, I can see in the action logs the following line:

makefile:136: target 'ci-test_AdditiveClosuresForCAP' does not exist

The same for other packages like AttributeCategoryForCAP. Maybe investigating that and comparing with old actions might solve the issue.

You mean lines such as

make: Entering directory '/home/gap/.gap/pkg/CAP_project'
makefile:121: target 'ci-test_ActionsForCAP' does not exist
make: Leaving directory '/home/gap/.gap/pkg/CAP_project'
make -C ActionsForCAP ci-test
make: Entering directory '/home/gap/.gap/pkg/CAP_project'
makefile:124: target 'ci-test_AttributeCategoryForCAP' does not exist
make: Leaving directory '/home/gap/.gap/pkg/CAP_project'
make -C AttributeCategoryForCAP ci-test
make: Entering directory '/home/gap/.gap/pkg/CAP_project'
makefile:127: target 'ci-test_CartesianCategories' does not exist
make: Leaving directory '/home/gap/.gap/pkg/CAP_project'
make -C CartesianCategories ci-test

? They are in all the action logs, even the ones succeeding.

[codecov]

Codecov Report

Attention: Patch coverage is 94.03095% with 81 lines in your changes missing coverage. Please review.

Project coverage is 81.74%. Comparing base (3d391cc) to head (486fc89).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
...losuresForCAP/gap/AdditiveClosureDerivedMethods.gi	87.98%	40 Missing ⚠️
...resForCAP/gap/MethodRecordInstallations.autogen.gi	94.83%	28 Missing ⚠️
...ategoriesForCAP/gap/FreydCategoriesMethodRecord.gi	88.15%	9 Missing ⚠️
...iesForCAP/gap/MethodRecordInstallations.autogen.gi	57.14%	3 Missing ⚠️
LinearAlgebraForCAP/gap/LinearAlgebraForCAP.gi	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1758      +/-   ##
==========================================
+ Coverage   81.70%   81.74%   +0.03%     
==========================================
  Files         569      576       +7     
  Lines       80750    80850     +100     
==========================================
+ Hits        65976    66089     +113     
+ Misses      14774    14761      -13     

Flag	Coverage Δ
ActionsForCAP	64.04% <ø> (ø)
AdditiveClosuresForCAP	82.09% <94.58%> (?)
AttributeCategoryForCAP	90.45% <ø> (ø)
CAP	86.41% <100.00%> (ø)
CartesianCategories	89.38% <ø> (ø)
CompilerForCAP	95.89% <100.00%> (ø)
ComplexesAndFilteredObjectsForCAP	73.55% <ø> (ø)
FreydCategoriesForCAP	83.19% <86.51%> (+1.04%)	⬆️
GeneralizedMorphismsForCAP	61.73% <ø> (ø)
GradedModulePresentationsForCAP	44.62% <ø> (ø)
GroupRepresentationsForCAP	71.92% <ø> (ø)
GroupsAsCategoriesForCAP	96.71% <100.00%> (+0.01%)	⬆️
HomologicalAlgebraForCAP	73.21% <ø> (ø)
InternalExteriorAlgebraForCAP	93.09% <ø> (ø)
LinearAlgebraForCAP	57.41% <75.00%> (ø)
ModulePresentationsForCAP	75.03% <100.00%> (+0.02%)	⬆️
ModulesOverLocalRingsForCAP	90.70% <ø> (ø)
MonoidalCategories	89.84% <ø> (ø)
ToricSheaves	21.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mohamed-barakat]

Wow, congratulations :)