Skip to content

Add Gryfsmart integration #137753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from
Open

Conversation

karlowiczpl
Copy link

Breaking change

The Gryf Smart integration is truly an impressive solution. It is based on a distributed RS232 communication system with a local push architecture, ensuring the highest level of security. This setup provides an enormous gateway to the world for the Gryf Smart system, offering both reliability and scalability. It's an innovative approach that opens up a wealth of possibilities for seamless automation and control.

Proposed change

This pull request introduces a new integration called GryfSmart.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • [x ] New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

I have done only tests for config flow

Checklist

  • [ x] The code change is tested and works locally.
  • [ x] Local tests pass. Your PR cannot be merged unless tests pass
  • [ x] There is no commented out code in this PR.
  • [ x] I have followed the development checklist
  • [ x] I have followed the perfect PR recommendations
  • [ x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @karlowiczpl

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Feb 7, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @karlowiczpl

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration needs to be updated to use the modern approach to integration building. Also, it seems like you want to base it on YAML configuration which we no longer support.

@karlowiczpl karlowiczpl reopened this Feb 9, 2025
@karlowiczpl karlowiczpl marked this pull request as ready for review February 9, 2025 21:10
@home-assistant home-assistant bot requested a review from balloob February 9, 2025 21:10
@home-assistant home-assistant bot dismissed stale reviews from themself February 9, 2025 21:10

Stale

@abmantis abmantis changed the title Gryfsmart Add Gryfsmart integration Feb 17, 2025
@karlowiczpl
Copy link
Author

Hey @balloob , do you have an estimate of when you might be able to review this PR?

@abmantis
Copy link
Contributor

Hey @karlowiczpl ! Marking this as draft since there are CI checks that are failing. Please take a look at them.

By the way, I recommend that you setup precommit, since it can help a ensuring that everything is OK before pushing.

Thanks!

@abmantis abmantis marked this pull request as draft March 19, 2025 11:44
Copy link
Contributor

@abmantis abmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a lot of previous review comments that were marked as resolved, but the code was not updated. I marked them as unresolved again.
Maybe forgot to push some commits?

@karlowiczpl
Copy link
Author

Hi, I accidentally pushed the wrong commit, but everything should be fixed now

@karlowiczpl karlowiczpl marked this pull request as ready for review March 19, 2025 12:01
@karlowiczpl
Copy link
Author

Hi @abmantis , why doesn't my PR get a review, thanks on advance

@abmantis
Copy link
Contributor

abmantis commented Apr 6, 2025

Hi @abmantis , why doesn't my PR get a review, thanks on advance

Hey. I understand your frustration and interest in getting this moving faster. I have been there too :) I know it can be annoying to see weeks pass and no reviews... But, as our docs mention:

Don't contact contributors, code owners, core team members, or other reviewers directly about a PR, or ping/mention them in a PR to ask for a review. While you probably mean this in a friendly way, it can be perceived as annoying or demanding. Instead, our bots will handle the pinging of the right people, and: have a bit of patience :)

Just try to keep your PR updated with dev from time to time, and someone will pick it up eventually. As you can see, we have a looot of PRs to review. If you can help and review some, it would also be great!

I would also recommend avoiding force-pushing, since it makes it harder to review the diff of new commits on Github.

By the way, this page has a lot of great info about the process we all use here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants