-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
Add Gryfsmart integration #137753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add Gryfsmart integration #137753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @karlowiczpl
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @karlowiczpl
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integration needs to be updated to use the modern approach to integration building. Also, it seems like you want to base it on YAML configuration which we no longer support.
5ca0e08
to
01920cc
Compare
d6764b2
to
c6ae577
Compare
Hey @balloob , do you have an estimate of when you might be able to review this PR? |
Hey @karlowiczpl ! Marking this as draft since there are CI checks that are failing. Please take a look at them. By the way, I recommend that you setup Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were a lot of previous review comments that were marked as resolved, but the code was not updated. I marked them as unresolved again.
Maybe forgot to push some commits?
Hi, I accidentally pushed the wrong commit, but everything should be fixed now |
Hi @abmantis , why doesn't my PR get a review, thanks on advance |
Hey. I understand your frustration and interest in getting this moving faster. I have been there too :) I know it can be annoying to see weeks pass and no reviews... But, as our docs mention:
Just try to keep your PR updated with I would also recommend avoiding force-pushing, since it makes it harder to review the diff of new commits on Github. By the way, this page has a lot of great info about the process we all use here. |
Breaking change
The Gryf Smart integration is truly an impressive solution. It is based on a distributed RS232 communication system with a local push architecture, ensuring the highest level of security. This setup provides an enormous gateway to the world for the Gryf Smart system, offering both reliability and scalability. It's an innovative approach that opens up a wealth of possibilities for seamless automation and control.
Proposed change
This pull request introduces a new integration called GryfSmart.
Type of change
Additional information
I have done only tests for config flow
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: