Add Gryfsmart integration #137753

karlowiczpl · 2025-02-07T21:29:55Z

Breaking change

The Gryf Smart integration is truly an impressive solution. It is based on a distributed RS232 communication system with a local push architecture, ensuring the highest level of security. This setup provides an enormous gateway to the world for the Gryf Smart system, offering both reliability and scalability. It's an innovative approach that opens up a wealth of possibilities for seamless automation and control.

Proposed change

This pull request introduces a new integration called GryfSmart.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
[x ] New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

I have done only tests for config flow

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Gryfsmart.markdown home-assistant.io#37355 (review)
Link to developer documentation pull request: Gryfsmart.markdown home-assistant.io#37355 (review)
Link to frontend pull request: https://github.com/karlowiczpl/ha_gryf_smart_brands

Checklist

[ x] The code change is tested and works locally.
[ x] Local tests pass. Your PR cannot be merged unless tests pass
[ x] There is no commented out code in this PR.
[ x] I have followed the development checklist
[ x] I have followed the perfect PR recommendations
[ x] The code has been formatted using Ruff (ruff format homeassistant tests)
[ x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ x] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ x] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ x] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

[ x] I have reviewed two other open pull requests in this repository.

home-assistant

Hi @karlowiczpl

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant · 2025-02-07T21:30:00Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

home-assistant

When adding new integrations, limit included platforms to a single platform. Please reduce this PR to a single platform

home-assistant

Hi @karlowiczpl

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

balloob

Integration needs to be updated to use the modern approach to integration building. Also, it seems like you want to base it on YAML configuration which we no longer support.

homeassistant/components/gryfsmart/__init__.py

homeassistant/components/gryfsmart/binary_sensor.py

homeassistant/components/gryfsmart/climate.py

homeassistant/components/gryfsmart/const.py

homeassistant/components/gryfsmart/entity.py

homeassistant/components/gryfsmart/schema.py

Stale

homeassistant/components/gryfsmart/__init__.py

homeassistant/components/gryfsmart/config_flow.py

karlowiczpl · 2025-02-23T20:39:50Z

Hey @balloob , do you have an estimate of when you might be able to review this PR?

abmantis · 2025-03-19T11:44:24Z

Hey @karlowiczpl ! Marking this as draft since there are CI checks that are failing. Please take a look at them.

By the way, I recommend that you setup precommit, since it can help a ensuring that everything is OK before pushing.

Thanks!

abmantis

There were a lot of previous review comments that were marked as resolved, but the code was not updated. I marked them as unresolved again.
Maybe forgot to push some commits?

karlowiczpl · 2025-03-19T12:00:53Z

Hi, I accidentally pushed the wrong commit, but everything should be fixed now

karlowiczpl · 2025-04-04T16:06:08Z

Hi @abmantis , why doesn't my PR get a review, thanks on advance

abmantis · 2025-04-06T22:47:05Z

Hi @abmantis , why doesn't my PR get a review, thanks on advance

Hey. I understand your frustration and interest in getting this moving faster. I have been there too :) I know it can be annoying to see weeks pass and no reviews... But, as our docs mention:

Don't contact contributors, code owners, core team members, or other reviewers directly about a PR, or ping/mention them in a PR to ask for a review. While you probably mean this in a friendly way, it can be perceived as annoying or demanding. Instead, our bots will handle the pinging of the right people, and: have a bit of patience :)

Just try to keep your PR updated with dev from time to time, and someone will pick it up eventually. As you can see, we have a looot of PRs to review. If you can help and review some, it would also be great!

I would also recommend avoiding force-pushing, since it makes it harder to review the diff of new commits on Github.

By the way, this page has a lot of great info about the process we all use here.

joostlek · 2025-05-09T14:32:47Z

homeassistant/components/gryfsmart/__init__.py

+
+async def async_setup_entry(
+    hass: HomeAssistant,
+    entry: ConfigEntry,


extend the config entry type and add the data you put in entry.runtime_data there

joostlek · 2025-05-09T14:33:09Z

homeassistant/components/gryfsmart/__init__.py

+    entry.runtime_data[CONF_DEVICE_DATA] = {
+        "identifiers": {(DOMAIN, "Gryf Smart", entry.unique_id)},
+        "name": f"Gryf Smart {entry.unique_id}",
+        "manufacturer": "Gryf Smart",
+        "model": "serial",
+        "sw_version": "1.0.0",
+        "hw_version": "1.0.0",
+    }


We don't need to store this one in here

joostlek · 2025-05-09T14:33:18Z

homeassistant/components/gryfsmart/config_flow.py

+        return True
+
+
+class GryfSmartConfigFlow(config_entries.ConfigFlow, domain=DOMAIN):


Suggested change

class GryfSmartConfigFlow(config_entries.ConfigFlow, domain=DOMAIN):

class GryfSmartConfigFlow(ConfigFlow, domain=DOMAIN):

joostlek · 2025-05-09T14:33:24Z

homeassistant/components/gryfsmart/config_flow.py

+    """Gryf Smart ConfigFlow."""
+
+    VERSION = 1
+    CONNECTION_CLASS = config_entries.CONN_CLASS_LOCAL_PUSH


Suggested change

CONNECTION_CLASS = config_entries.CONN_CLASS_LOCAL_PUSH

joostlek · 2025-05-09T14:33:55Z

homeassistant/components/gryfsmart/config_flow.py

+                    vol.Required(CONF_PORT, default=DEFAULT_PORT): str,
+                    vol.Required(CONF_MODULE_COUNT, default=1): int,


what's a port and a module?

joostlek · 2025-05-09T14:34:37Z

homeassistant/components/gryfsmart/config_flow.py

+    async def async_step_device_menu(
+        self, user_input: dict[str, Any] | None = None
+    ) -> config_entries.ConfigFlowResult:
+        """Show menu step."""
+
+        return self.async_show_menu(
+            step_id="device_menu",
+            menu_options=CONFIG_FLOW_MENU_OPTIONS,
+        )


How does one add devices without the use of Home Assistant?

joostlek · 2025-05-09T14:35:05Z

homeassistant/components/gryfsmart/entity.py

+class _EntityBase(Entity):
+    """Base Entity for Gryf Smart."""
+
+    _attr_should_poll = False
+    _attr_entity_registry_enabled_default = True
+
+    _api: GryfApi
+    _device: _GryfDevice
+    _attr_unique_id: str | None
+
+    @property
+    def name(self) -> str:
+        return self._device.name


not sure why we have this

joostlek · 2025-05-09T14:35:20Z

homeassistant/components/gryfsmart/entity.py

+    _config_entry: ConfigEntry
+
+    def __init__(
+        self,
+        config_entry: ConfigEntry,
+        device: _GryfDevice,
+    ) -> None:
+        """Init Gryf config flow entity."""
+
+        self._device = device
+        self._config_entry = config_entry
+        super().__init__()


let's not keep a reference to the config entry in there

github-actions · 2025-07-08T15:06:43Z

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

home-assistant bot previously requested changes Feb 7, 2025

View reviewed changes

home-assistant bot added cla-needed has-tests new-integration integration: gryfsmart labels Feb 7, 2025

home-assistant bot marked this pull request as draft February 7, 2025 21:29

home-assistant bot added the quality-scale label Feb 7, 2025

home-assistant bot previously requested changes Feb 7, 2025

View reviewed changes

home-assistant bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Feb 7, 2025

karlowiczpl added 12 commits February 8, 2025 11:09

Initialise commit

08dc212

Initialise commit

5b1f6a9

Initialise commit

068d302

Initialise commit

c611933

add sensor platform

ed4011e

add binary sensor platform

4409267

1.0

a7db884

added GryfSmart integration

fc9c7c6

added GryfSmart integration

ab34997

added lights platform to GryfSmart

2c0fd88

Added light platform to gryfSmart Integration

ab8dbfe

Added light platform to gryfSmart Integration

7529baf

balloob requested changes Feb 8, 2025

View reviewed changes

karlowiczpl and others added 2 commits February 9, 2025 11:36

Added climate platform for GryfSmart integration

4b208a0

Merge branch 'dev' into lightPlatform

c6ae577

karlowiczpl force-pushed the gryfsmart branch from 5ca0e08 to 01920cc Compare February 9, 2025 10:40

Merge branch 'dev' into gryfsmart

40f725c

CloCkWeRX reviewed Feb 10, 2025

View reviewed changes

homeassistant/components/gryfsmart/__init__.py Outdated Show resolved Hide resolved

CloCkWeRX reviewed Feb 10, 2025

View reviewed changes

homeassistant/components/gryfsmart/config_flow.py Outdated Show resolved Hide resolved

c0ffeeca7 mentioned this pull request Feb 10, 2025

Gryfsmart.markdown home-assistant/home-assistant.io#37355

Closed

6 tasks

karlowiczpl and others added 2 commits February 10, 2025 09:19

GryfSmart comments removed

5cf7f10

Merge branch 'dev' into gryfsmart

00d26a9

karlowiczpl requested a review from CloCkWeRX February 10, 2025 08:22

karlowiczpl closed this Feb 12, 2025

karlowiczpl reopened this Feb 12, 2025

karlowiczpl added 2 commits February 12, 2025 18:18

Merge branch 'dev' into gryfsmart

5f17d09

Merge branch 'dev' into gryfsmart

8e373e6

abmantis changed the title ~~Gryfsmart~~ Add Gryfsmart integration Feb 17, 2025

Merge branch 'dev' into gryfsmart

7818756

abmantis marked this pull request as draft March 19, 2025 11:44

abmantis reviewed Mar 19, 2025

View reviewed changes

karlowiczpl force-pushed the gryfsmart branch from 86128bb to 7818756 Compare March 19, 2025 11:58

karlowiczpl marked this pull request as ready for review March 19, 2025 12:01

Merge branch 'dev' into gryfsmart

96f0393

joostlek requested changes May 9, 2025

View reviewed changes

home-assistant bot marked this pull request as draft May 9, 2025 14:35

github-actions bot added the stale label Jul 8, 2025

github-actions bot closed this Jul 15, 2025

github-actions bot locked and limited conversation to collaborators Jul 16, 2025

		return True


		class GryfSmartConfigFlow(config_entries.ConfigFlow, domain=DOMAIN):

	class GryfSmartConfigFlow(config_entries.ConfigFlow, domain=DOMAIN):
	class GryfSmartConfigFlow(ConfigFlow, domain=DOMAIN):

		vol.Required(CONF_PORT, default=DEFAULT_PORT): str,
		vol.Required(CONF_MODULE_COUNT, default=1): int,

Uh oh!

Add Gryfsmart integration #137753

Add Gryfsmart integration #137753

Uh oh!

Conversation

karlowiczpl commented Feb 7, 2025

Breaking change

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant bot left a comment

Choose a reason for hiding this comment

Uh oh!

home-assistant bot commented Feb 7, 2025

Uh oh!

home-assistant bot left a comment

Choose a reason for hiding this comment

Uh oh!

home-assistant bot left a comment

Choose a reason for hiding this comment

Uh oh!

balloob left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

karlowiczpl commented Feb 23, 2025

Uh oh!

abmantis commented Mar 19, 2025

Uh oh!

abmantis left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karlowiczpl commented Mar 19, 2025

Uh oh!

karlowiczpl commented Apr 4, 2025

Uh oh!

abmantis commented Apr 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

balloob left a comment •

edited

Loading

abmantis left a comment •

edited

Loading