Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensor as entity platform on MQTT subentries #139899

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Mar 6, 2025

Proposed change

Add the MQTT sensor platform to subentry support.
Based on/needed:

Follow up PR's:

Needs: home-assistant/frontend#24733

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • [x ] The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Mar 6, 2025

Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jbouwh jbouwh force-pushed the mqtt-subentry-sensor branch 2 times, most recently from b310ba3 to dcce889 Compare March 6, 2025 17:11
@jbouwh jbouwh force-pushed the mqtt-subentry-sensor branch 6 times, most recently from c264bfd to 2d4a62e Compare March 11, 2025 18:15
@jbouwh jbouwh force-pushed the mqtt-subentry-sensor branch 5 times, most recently from 7967a3d to b002d8d Compare March 14, 2025 13:02
@jbouwh jbouwh force-pushed the mqtt-subentry-sensor branch from b002d8d to 89aa5cc Compare March 14, 2025 14:03
@jbouwh jbouwh marked this pull request as ready for review March 14, 2025 14:06
@jbouwh jbouwh force-pushed the mqtt-subentry-sensor branch from bb12348 to d9e45cf Compare March 22, 2025 14:45
@jbouwh
Copy link
Contributor Author

jbouwh commented Mar 24, 2025

Frontend PR was merged

PLATFORM_ENTITY_FIELDS = {
Platform.NOTIFY.value: {},
Platform.SENSOR.value: {
CONF_DEVICE_CLASS: PlatformField(SENSOR_DEVICE_CLASS_SELECTOR, False, str),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not easy to understand what the False does.

I'd suggest to make the PlatformField kwarg-only (that can happen in a separate PR though)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this one for a future PR

@jbouwh jbouwh requested a review from emontnemery March 25, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants