Add sensor as entity platform on MQTT subentries #139899

jbouwh · 2025-03-06T07:19:42Z

Proposed change

Add the MQTT sensor platform to subentry support.
Based on/needed:

Add initial MQTT subentry support for notify entities #138461 (Main subentry PR with Notify platform)
Add availability support for MQTT subentries #138673 (Availability)

Follow up PR's:

Move QoS setting to shared device properties in MQTT device subentries configuration #141369 (QoS option to device settings)
Add switch as entity platform on MQTT subentries #140658 (Switch)
Add light as entity platform on MQTT subentries #141345 (Light)

Needs: ~~home-assistant/frontend#24733~~

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Add MQTT sensor subentry support home-assistant.io#37981
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

[x ] The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2025-03-06T07:19:49Z

Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

jbouwh · 2025-03-24T17:12:22Z

Frontend PR was merged

…uded from reconfig

homeassistant/components/mqtt/config_flow.py

homeassistant/components/mqtt/sensor.py

homeassistant/components/mqtt/config_flow.py

emontnemery · 2025-03-26T08:22:20Z

homeassistant/components/mqtt/strings.json

+    "device_class_sensor": {
+      "options": {
+        "apparent_power": "[%key:component::sensor::entity_component::apparent_power::name%]",
+        "area": "[%key:component::sensor::entity_component::area::name%]",
+        "aqi": "[%key:component::sensor::entity_component::aqi::name%]",
+        "atmospheric_pressure": "[%key:component::sensor::entity_component::atmospheric_pressure::name%]",
+        "battery": "[%key:component::sensor::entity_component::battery::name%]",
+        "blood_glucose_concentration": "[%key:component::sensor::entity_component::blood_glucose_concentration::name%]",
+        "carbon_dioxide": "[%key:component::sensor::entity_component::carbon_dioxide::name%]",
+        "carbon_monoxide": "[%key:component::sensor::entity_component::carbon_monoxide::name%]",
+        "conductivity": "[%key:component::sensor::entity_component::conductivity::name%]",
+        "current": "[%key:component::sensor::entity_component::current::name%]",
+        "data_rate": "[%key:component::sensor::entity_component::data_rate::name%]",
+        "data_size": "[%key:component::sensor::entity_component::data_size::name%]",
+        "date": "[%key:component::sensor::entity_component::date::name%]",
+        "distance": "[%key:component::sensor::entity_component::distance::name%]",
+        "duration": "[%key:component::sensor::entity_component::duration::name%]",
+        "energy": "[%key:component::sensor::entity_component::energy::name%]",
+        "energy_distance": "[%key:component::sensor::entity_component::energy_distance::name%]",
+        "energy_storage": "[%key:component::sensor::entity_component::energy_storage::name%]",
+        "enum": "Enumeration",
+        "frequency": "[%key:component::sensor::entity_component::frequency::name%]",
+        "gas": "[%key:component::sensor::entity_component::gas::name%]",
+        "humidity": "[%key:component::sensor::entity_component::humidity::name%]",
+        "illuminance": "[%key:component::sensor::entity_component::illuminance::name%]",
+        "irradiance": "[%key:component::sensor::entity_component::irradiance::name%]",
+        "moisture": "[%key:component::sensor::entity_component::moisture::name%]",
+        "monetary": "[%key:component::sensor::entity_component::monetary::name%]",
+        "nitrogen_dioxide": "[%key:component::sensor::entity_component::nitrogen_dioxide::name%]",
+        "nitrogen_monoxide": "[%key:component::sensor::entity_component::nitrogen_monoxide::name%]",
+        "nitrous_oxide": "[%key:component::sensor::entity_component::nitrous_oxide::name%]",
+        "ozone": "[%key:component::sensor::entity_component::ozone::name%]",
+        "ph": "[%key:component::sensor::entity_component::ph::name%]",
+        "pm1": "[%key:component::sensor::entity_component::pm1::name%]",
+        "pm10": "[%key:component::sensor::entity_component::pm10::name%]",
+        "pm25": "[%key:component::sensor::entity_component::pm25::name%]",
+        "power": "[%key:component::sensor::entity_component::power::name%]",
+        "power_factor": "[%key:component::sensor::entity_component::power_factor::name%]",
+        "precipitation": "[%key:component::sensor::entity_component::precipitation::name%]",
+        "precipitation_intensity": "[%key:component::sensor::entity_component::precipitation_intensity::name%]",
+        "pressure": "[%key:component::sensor::entity_component::pressure::name%]",
+        "reactive_power": "[%key:component::sensor::entity_component::reactive_power::name%]",
+        "signal_strength": "[%key:component::sensor::entity_component::signal_strength::name%]",
+        "sound_pressure": "[%key:component::sensor::entity_component::sound_pressure::name%]",
+        "speed": "[%key:component::sensor::entity_component::speed::name%]",
+        "sulphur_dioxide": "[%key:component::sensor::entity_component::sulphur_dioxide::name%]",
+        "temperature": "[%key:component::sensor::entity_component::temperature::name%]",
+        "timestamp": "[%key:component::sensor::entity_component::timestamp::name%]",
+        "volatile_organic_compounds": "[%key:component::sensor::entity_component::volatile_organic_compounds::name%]",
+        "volatile_organic_compounds_parts": "[%key:component::sensor::entity_component::volatile_organic_compounds::name%]",
+        "voltage": "[%key:component::sensor::entity_component::voltage::name%]",
+        "volume": "[%key:component::sensor::entity_component::volume::name%]",
+        "volume_flow_rate": "[%key:component::sensor::entity_component::volume_flow_rate::name%]",
+        "volume_storage": "[%key:component::sensor::entity_component::volume_storage::name%]",
+        "water": "[%key:component::sensor::entity_component::water::name%]",
+        "weight": "[%key:component::sensor::entity_component::weight::name%]",
+        "wind_direction": "[%key:component::sensor::entity_component::wind_direction::name%]",
+        "wind_speed": "[%key:component::sensor::entity_component::wind_speed::name%]"
+      }
+    },


Do we have a plan for how we can avoid having to add this list to integrations? Can we maybe allow a translation_domain or something on selector?

I have asked @joostlek if he had an idea, else I'll pick up this up in a follow up PR

Sure, it has to be done in a separate PR.

homeassistant/components/mqtt/config_flow.py

jbouwh

Ready for review

emontnemery

Thanks, @jbouwh 👍

jbouwh · 2025-03-26T12:34:32Z

Thanks!

home-assistant bot added cla-signed core has-tests integration: mqtt new-feature labels Mar 6, 2025

home-assistant bot assigned emontnemery and bdraco Mar 6, 2025

home-assistant bot added by-code-owner Quality Scale: platinum labels Mar 6, 2025

jbouwh force-pushed the mqtt-subentry-sensor branch 2 times, most recently from b310ba3 to dcce889 Compare March 6, 2025 17:11

jbouwh mentioned this pull request Mar 6, 2025

Add initial MQTT subentry support for notify entities #138461

Merged

19 tasks

jbouwh force-pushed the mqtt-subentry-sensor branch 6 times, most recently from c264bfd to 2d4a62e Compare March 11, 2025 18:15

jbouwh force-pushed the mqtt-subentry-sensor branch 5 times, most recently from 7967a3d to b002d8d Compare March 14, 2025 13:02

jbouwh mentioned this pull request Mar 14, 2025

Add availability support for MQTT subentries #138673

Merged

19 tasks

jbouwh force-pushed the mqtt-subentry-sensor branch from b002d8d to 89aa5cc Compare March 14, 2025 14:03

jbouwh mentioned this pull request Mar 14, 2025

Add MQTT sensor subentry support home-assistant/home-assistant.io#37981

Merged

8 tasks

jbouwh marked this pull request as ready for review March 14, 2025 14:06

jbouwh requested review from emontnemery and bdraco as code owners March 14, 2025 14:06

Use helper to apply suggested values from component config

54f138a

jbouwh removed the awaiting-frontend label Mar 24, 2025

Rename to Add option

cec98b0

jbouwh mentioned this pull request Mar 25, 2025

Add light as entity platform on MQTT subentries #141345

Merged

24 tasks

Fix schema builder not hiding empty sections and removing fields excl…

d5df517

…uded from reconfig

jbouwh commented Mar 25, 2025

View reviewed changes

homeassistant/components/mqtt/config_flow.py Outdated Show resolved Hide resolved

jbouwh and others added 3 commits March 25, 2025 09:31

Do not hide advanced settings if values are available or are defaults

00fa76c

Merge branch 'dev' into mqtt-subentry-sensor

018b87f

Improve spelling and Learn more links

56ccce5

jbouwh mentioned this pull request Mar 25, 2025

Move QoS setting to shared device properties in MQTT device subentries configuration #141369

Merged

24 tasks

jbouwh added 2 commits March 25, 2025 13:39

Improve unit of measurement validation

4e9cf0d

Fix UOM selector and translation strings

2a7667b

emontnemery reviewed Mar 25, 2025

View reviewed changes

jbouwh added 2 commits March 25, 2025 15:13

Address comments from code review

303a599

Remove stale comment

70a9561

jbouwh requested a review from emontnemery March 25, 2025 18:39

emontnemery reviewed Mar 26, 2025

View reviewed changes

jbouwh added 2 commits March 26, 2025 08:47

Rename selector constant, split validator

4bd9634

Simplify config validator

09a2cd2

emontnemery reviewed Mar 26, 2025

View reviewed changes

homeassistant/components/mqtt/config_flow.py Outdated Show resolved Hide resolved

Return tuple with config and errors for config validation

cd5a865

jbouwh commented Mar 26, 2025

View reviewed changes

emontnemery approved these changes Mar 26, 2025

View reviewed changes

jbouwh merged commit 77bf977 into dev Mar 26, 2025
48 checks passed

jbouwh deleted the mqtt-subentry-sensor branch March 26, 2025 12:34

jbouwh added this to the 2025.4.0b0 milestone Mar 26, 2025

frenck removed this from the 2025.4.0b0 milestone Mar 26, 2025

github-actions bot locked and limited conversation to collaborators Mar 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add sensor as entity platform on MQTT subentries #139899

Add sensor as entity platform on MQTT subentries #139899

Uh oh!

jbouwh commented Mar 6, 2025 •

edited

Loading

Uh oh!

home-assistant bot commented Mar 6, 2025

Uh oh!

jbouwh commented Mar 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emontnemery Mar 26, 2025

Uh oh!

jbouwh Mar 26, 2025

Uh oh!

emontnemery Mar 26, 2025

Uh oh!

Uh oh!

jbouwh left a comment

Uh oh!

emontnemery left a comment

Uh oh!

Uh oh!

jbouwh commented Mar 26, 2025

Uh oh!

Uh oh!

Uh oh!

Add sensor as entity platform on MQTT subentries #139899

Add sensor as entity platform on MQTT subentries #139899

Uh oh!

Conversation

jbouwh commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant bot commented Mar 6, 2025

Uh oh!

jbouwh commented Mar 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emontnemery Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

jbouwh Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

emontnemery Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jbouwh left a comment

Choose a reason for hiding this comment

Uh oh!

emontnemery left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jbouwh commented Mar 26, 2025

Uh oh!

Uh oh!

jbouwh commented Mar 6, 2025 •

edited

Loading