-
-
Notifications
You must be signed in to change notification settings - Fork 33k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensor as entity platform on MQTT subentries #139899
base: dev
Are you sure you want to change the base?
Conversation
Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
b310ba3
to
dcce889
Compare
c264bfd
to
2d4a62e
Compare
7967a3d
to
b002d8d
Compare
b002d8d
to
89aa5cc
Compare
bb12348
to
d9e45cf
Compare
Frontend PR was merged |
…uded from reconfig
PLATFORM_ENTITY_FIELDS = { | ||
Platform.NOTIFY.value: {}, | ||
Platform.SENSOR.value: { | ||
CONF_DEVICE_CLASS: PlatformField(SENSOR_DEVICE_CLASS_SELECTOR, False, str), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not easy to understand what the False
does.
I'd suggest to make the PlatformField
kwarg-only (that can happen in a separate PR though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave this one for a future PR
Proposed change
Add the MQTT sensor platform to subentry support.
Based on/needed:
Follow up PR's:
Needs:
home-assistant/frontend#24733Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: