-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensor as entity platform on MQTT subentries #139899
Merged
+993
−97
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
f6e962b
Add sensor as entity platform on MQTT subentries
jbouwh 4dff885
Fix typo
jbouwh f34271e
Improve device class data description
jbouwh 89faadb
Tweak
jbouwh d74be02
Rework reconfig calculation
jbouwh 3f0701a
Filter out last_reset_value_template if state class is not total
jbouwh e6e0477
Collapse expire after as advanced setting
jbouwh 19f6cc0
Update suggested_display_precision translation strings
jbouwh d9e45cf
Make options and last_reset_template conditional, use sections for ad…
jbouwh 55f027a
Merge branch 'dev' into mqtt-subentry-sensor
jbouwh 3cb26a6
Ensure options are removed properly
jbouwh a00ffac
Improve sensor options label, ensure UOM is set when device class has…
jbouwh 4b1f968
Merge branch 'dev' into mqtt-subentry-sensor
jbouwh de10613
Merge branch 'dev' into mqtt-subentry-sensor
jbouwh 54f138a
Use helper to apply suggested values from component config
jbouwh cec98b0
Rename to `Add option`
jbouwh d5df517
Fix schema builder not hiding empty sections and removing fields excl…
jbouwh 00fa76c
Do not hide advanced settings if values are available or are defaults
jbouwh 018b87f
Merge branch 'dev' into mqtt-subentry-sensor
jbouwh 56ccce5
Improve spelling and Learn more links
jbouwh 4e9cf0d
Improve unit of measurement validation
jbouwh 2a7667b
Fix UOM selector and translation strings
jbouwh 303a599
Address comments from code review
jbouwh 70a9561
Remove stale comment
jbouwh 4bd9634
Rename selector constant, split validator
jbouwh 09a2cd2
Simplify config validator
jbouwh cd5a865
Return tuple with config and errors for config validation
jbouwh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a plan for how we can avoid having to add this list to integrations? Can we maybe allow a translation_domain or something on selector?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have asked @joostlek if he had an idea, else I'll pick up this up in a follow up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, it has to be done in a separate PR.