-
-
Notifications
You must be signed in to change notification settings - Fork 33k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add switch as entity platform on MQTT subentries #140658
base: dev
Are you sure you want to change the base?
Conversation
Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@@ -342,9 +376,77 @@ | |||
} | |||
}, | |||
"selector": { | |||
"device_class_sensor": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OT for this change. But this is going to get messy fast if more config flow integrations need to select a device class (and/or units)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, already discussed this with Erik and Joost. But not sure we have an alternative yet.
5f800f2
to
ab32f9f
Compare
d1c7425
to
5c72f06
Compare
5c72f06
to
5747703
Compare
5747703
to
cd585df
Compare
Proposed change
Add the MQTT sensor platform to subentry support.
Based on/needed:
Follow up PR:
#141345 (Light)
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: