Skip to content

Conversation

@chemelli74
Copy link
Contributor

Proposed change

Add quality scale to SamsungTV

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Apr 4, 2025

Hey there @epenet, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of samsungtv can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign samsungtv Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@chemelli74 chemelli74 changed the title Add quality scale to SamsungTV Add quality scale (bronze) to SamsungTV Apr 6, 2025
@chemelli74 chemelli74 marked this pull request as ready for review April 6, 2025 13:02
@chemelli74 chemelli74 requested review from a team and epenet as code owners April 6, 2025 13:02
@chemelli74 chemelli74 changed the title Add quality scale (bronze) to SamsungTV Add quality scale (silver) to SamsungTV Apr 11, 2025
@chemelli74 chemelli74 changed the title Add quality scale (silver) to SamsungTV Add quality scale to SamsungTV Apr 14, 2025
zweckj
zweckj previously requested changes Apr 24, 2025
@home-assistant home-assistant bot marked this pull request as draft April 24, 2025 19:17
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@chemelli74
Copy link
Contributor Author

Updated everything as requested + moved needed items to todo so we can merge.

@chemelli74 chemelli74 marked this pull request as ready for review April 25, 2025 12:04
@chemelli74 chemelli74 marked this pull request as ready for review May 7, 2025 16:58
@home-assistant home-assistant bot requested a review from joostlek May 7, 2025 16:58
@chemelli74 chemelli74 dismissed stale reviews from zweckj and joostlek May 9, 2025 09:03

stale

@chemelli74 chemelli74 changed the title Add quality scale to SamsungTV Add quality scale bronze to SamsungTV May 9, 2025
@zweckj zweckj merged commit 5ef054f into home-assistant:dev Jun 24, 2025
33 of 34 checks passed
@chemelli74 chemelli74 deleted the chemelli74-samsungtv-quality-scale branch June 24, 2025 19:56
@chemelli74
Copy link
Contributor Author

Thx so much !!!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants