Remove entity name input from Samsung TV config flow

[chemelli74]

Breaking change

Proposed change

Remove entity name input from Samsung TV config flow as requested by @joostlek here: #142288 (comment)

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:
• Link to developer documentation pull request:
• Link to frontend pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @epenet, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of samsungtv can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign samsungtv Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[joostlek]

Why are we testing is None?

[chemelli74]

Only because other fields are tested for None as well.

PR updated

[epenet]

I think conf_name needs a thorough review, as it seems to be passed and used by the legacy bridge

[jbouwh]

If name was set previously, then we still might want to respect this.

[epenet]

I think you need to update strings.json accordingly.

Also, could we drop CONF_NAME and self._name completely from the config-flow?
If #144254 is accepted, then it is no longer needed by the integration:

• in _async_get_and_check_device_info we can just set self._title without self._name
• in async_step_reauth_confirm, I think we should use reauth_entry.title for the title_placeholder and the description_placeholder
• in async_step_reauth_confirm_encrypted, I think we should also use reauth_entry.title for the title_placeholder and the description_placeholder
• in async_step_reauth, we can drop self._title assignment (not needed after changes above)

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.