Add set_program service to Miele #143442
Add set_program service to Miele #143442
Conversation
| duration: | ||
| selector: | ||
| number: | ||
| min: 0 | ||
| max: 240 | ||
| mode: box | ||
| unit_of_measurement: min | ||
| example: 120 | ||
| temperature: | ||
| selector: | ||
| number: | ||
| min: 100 | ||
| max: 300 | ||
| mode: box | ||
| unit_of_measurement: °C | ||
| example: 200 |
There was a problem hiding this comment.
I think I would recommend to split this into 2 services, one specific for ovens, since this way we at least avoid adding more things in the future imo
There was a problem hiding this comment.
I am not sure that it would make things easier for the users. Duration and temperature are optional for ovens. If you don't specify them, defaults for the selected program are used in the appliance. In addition it is not documented which models that support these parameters. I suggest that we keep it as on common set_program for all devices and await comments from the users. There has not been any complaints regaring this service action in the user base for the custom component.
There was a problem hiding this comment.
The thing I am most worried about is the slippery slope, so now we only have an oven, but in the future maybe an area for a robot vacuum or lawn mower, which in the end could make this service a mess.
Does every oven support this? Or only certain ones?
There was a problem hiding this comment.
It is not documented. But I have good reasons to believe that support is not complete across the entire portfolio. There are ovens, microwave ovens, steam/oven combos all with limited support in the public API. Then there are coffee systems, dishwashers, etc, The suggested service supports all known (as of today) implementations of set_program in the public API.
There was a problem hiding this comment.
Current service action is what is needed to support the most "controllable" ovens. A mandatory program_id, and optional duration and temperature. I don't see the point with a specific service for ovens. The API has been stable in this area since the beginning.
epenet
changed the title
Proposed change
Add service action
Set program.This action is used to start a program on applicable appliances. For ovens you can specify run time and target temperature, for other appliances you should just set program_id.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: