Skip to content

Add set_program service action to miele #38670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

astrandb
Copy link
Contributor

@astrandb astrandb commented Apr 22, 2025

Proposed change

Add documentation on service action for Miele integration

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated Miele integration documentation to include support for climate control devices such as refrigerators, freezers, and wine cabinets.
    • Added details about the new "Climate" category and supported platforms.
    • Introduced documentation for the new miele.set_program action, including usage instructions and parameter descriptions.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Apr 22, 2025
Copy link

netlify bot commented Apr 22, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 62dd03d
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/680a8131c999fc0008f5efc1
😎 Deploy Preview https://deploy-preview-38670--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Apr 22, 2025

📝 Walkthrough

Walkthrough

The documentation for the Miele integration was updated to reflect new support for climate control features and a new service action. The changes add the "Climate" category and platform, describe how climate entities can manage appliance temperatures, and introduce the miele.set_program action for starting appliance programs with specified parameters. Details on required and optional service attributes and instructions for identifying program IDs are included.

Changes

File(s) Change Summary
source/_integrations/miele.markdown Added "Climate" to supported categories and platforms; introduced a section on climate entity support describing multi-zone temperature control; relocated sensor details; documented new miele.set_program service action with usage instructions and parameters.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HomeAssistant
    participant MieleIntegration
    participant Appliance

    User->>HomeAssistant: Invoke miele.set_program (device_id, program_id, ...)
    HomeAssistant->>MieleIntegration: Process set_program request
    MieleIntegration->>Appliance: Send program start command with parameters
    Appliance-->>MieleIntegration: Acknowledge program start
    MieleIntegration-->>HomeAssistant: Confirm action result
    HomeAssistant-->>User: Notify of success/failure
Loading
sequenceDiagram
    participant User
    participant HomeAssistant
    participant MieleIntegration
    participant Appliance

    User->>HomeAssistant: Adjust climate entity (e.g., set temperature)
    HomeAssistant->>MieleIntegration: Forward climate control command
    MieleIntegration->>Appliance: Set target temperature for zone
    Appliance-->>MieleIntegration: Confirm temperature set
    MieleIntegration-->>HomeAssistant: Update climate state
    HomeAssistant-->>User: Reflect updated climate status
Loading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa32a94 and cfbc172.

📒 Files selected for processing (1)
  • source/_integrations/miele.markdown (4 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/miele.markdown

[uncategorized] ~110-~110: A punctuation mark might be missing here.
Context: ...the key state::programId::value_raw.| | duration | yes | Set desir...

(AI_EN_LECTOR_MISSING_PUNCTUATION)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (4)
source/_integrations/miele.markdown (4)

5-5: Frontmatter: Added 'Climate' category
The addition of the Climate category to ha_category correctly reflects the new climate entities in the integration.


15-15: Frontmatter: Added 'climate' to supported platforms
Including climate in ha_platforms accurately documents the support for climate entities.


84-89: New Climate section
The "### Climate" section and details block clearly explain the use of climate entities and supported zones. This aligns with Home Assistant documentation patterns.


109-113: Skip: Table punctuation false positive
The table markup and punctuation in the data attributes section is valid Markdown; the LanguageTool hint can be safely ignored.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~110-~110: A punctuation mark might be missing here.
Context: ...the key state::programId::value_raw.| | duration | yes | Set desir...

(AI_EN_LECTOR_MISSING_PUNCTUATION)

Comment on lines 100 to 113
## Actions

### Action `miele.set_program`

Set and start a program for applicable appliances. Note that the device must be in a state where it will accept a new program, for example, most washing machines must be in state `On`. An error message is displayed if the device did not accept the action command.
The service action can be set up by UI in Automations editor or Developer tools.

| Data attribute | Optional | Description |
| -------------- | -------- | ----------------------------------------------------------------------------------------------------------------- |
| `device_id` | no | Select device in GUI mode, then switch to YAML mode to see the device_id. |
| `program_id` | no | Enter the program_id number. The easiest way to find the number is to fetch a diagnostic download while running the actual program. Use the value from the key `state::programId::value_raw`.|
| `duration` | yes | Set desired program duration in minutes for ovens. |
| `temperature` | yes | Set desired target temperature for oven program. |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Enhancement: Add usage example for miele.set_program
Include a YAML snippet demonstrating how to call the miele.set_program service with device_id, program_id, and optional duration/temperature. This will help users to quickly apply the new action. For example:

service: miele.set_program
data:
  device_id: "abcdef123456"
  program_id: 3
  duration: 60     # in minutes
  temperature: 180 # in °C
🧰 Tools
🪛 LanguageTool

[uncategorized] ~110-~110: A punctuation mark might be missing here.
Context: ...the key state::programId::value_raw.| | duration | yes | Set desir...

(AI_EN_LECTOR_MISSING_PUNCTUATION)

c0ffeeca7
c0ffeeca7 previously approved these changes Apr 22, 2025
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @astrandb 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Apr 22, 2025
@astrandb astrandb changed the title MieleServiceAction2 Add set_program service action to miele Apr 24, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_integrations/miele.markdown (1)

86-90: Introduce 'Climate' documentation section
The new ### Climate section and its details clearly explain how users can control appliance temperatures and the number of zones. Consider including a brief YAML example to illustrate setting a temperature target, for example:

service: climate.set_temperature
target:
  entity_id: climate.fridge_zone_1
data:
  temperature: 4
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cfbc172 and 62dd03d.

📒 Files selected for processing (1)
  • source/_integrations/miele.markdown (4 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/miele.markdown

[uncategorized] ~107-~107: Possible missing comma found.
Context: ...ovens. Entities are created for up to 3 zones depending on the device capabilities. {...

(AI_HYDRA_LEO_MISSING_COMMA)

🪛 markdownlint-cli2 (0.17.2)
source/_integrations/miele.markdown

122-122: Tables should be surrounded by blank lines
null

(MD058, blanks-around-tables)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (3)
source/_integrations/miele.markdown (3)

5-5: Add 'Climate' to integration categories
Including "Climate" under ha_category ensures the Miele integration appears in the Climate section of Home Assistant, matching the newly added climate entities.


16-16: Register new 'climate' platform
Adding - climate in ha_platforms correctly declares support for climate entities in the Miele integration.


101-108: Relocate and preserve 'Sensor' section
The ### Sensor section has been moved below Light and retains the necessary details about operation state and temperature sensors across up to three zones. The content remains accurate and well-structured.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~107-~107: Possible missing comma found.
Context: ...ovens. Entities are created for up to 3 zones depending on the device capabilities. {...

(AI_HYDRA_LEO_MISSING_COMMA)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants