Mark dynamic-devices as exempt in Renault IQS #143450
Conversation
home-assistant
bot
added
cla-signed
code-quality
integration: renault
small-pr
epenet
force-pushed
the
epenet-20250422-1449
branch
from
fc02006 to
1b2c1f2
Compare
| dynamic-devices: | ||
| status: exempt | ||
| comment: Adding/removing a vehicle is a rare occurrence |
There was a problem hiding this comment.
It doesn't seem useful to trigger a lookup every x minutes for new vehicles - we'd be using up valuable hits and renault is already rate-limited per account.
It's more likely that if someone adds a new car they will just reload the integration
| Adding/removing a vehicle is a rare occurrence, and we don't want to | ||
| waste valuable hits on Renault API, which is rate-limited |
There was a problem hiding this comment.
This seems like odd reasoning to me: A rare occurrence + worrying about rate-limiting.
If I might suggest an alternative, could you trigger a config entry reload if the change is detected?
There was a problem hiding this comment.
There is no way to know without making a specific API "list vehicles" request
There was a problem hiding this comment.
@frenck are you suggesting that I should make an API call at regular interval to see if there are new vehicles?
If we are making a "list vehicles" call every few minutes we would need to reduce the interval for more important data calls.
I guess we could make a call every 24h, but seems a lot of work for very little benefit.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
SSIA
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: