Skip to content

Mark dynamic-devices as exempt in Renault IQS #143450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
epenet wants to merge 2 commits into from
+5 −1
Closed

Mark dynamic-devices as exempt in Renault IQS #143450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fda6f8
Mark dynamic-devices as exempt in Renault IQS
epenet Apr 22, 2025
052049d
Update homeassistant/components/renault/quality_scale.yaml
epenet Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion homeassistant/components/renault/quality_scale.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ rules:
docs-supported-functions: todo
docs-troubleshooting: done
docs-use-cases: todo
dynamic-devices: todo
dynamic-devices:
status: exempt
comment: |
Adding/removing a vehicle is a rare occurrence, and we don't want to
waste valuable hits on Renault API, which is rate-limited
Comment on lines +53 to +54
Copy link
Copy Markdown
Member

@frenck frenck Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like odd reasoning to me: A rare occurrence + worrying about rate-limiting.

If I might suggest an alternative, could you trigger a config entry reload if the change is detected?

Copy link
Copy Markdown
Contributor Author

@epenet epenet Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no way to know without making a specific API "list vehicles" request

Copy link
Copy Markdown
Contributor Author

@epenet epenet Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck are you suggesting that I should make an API call at regular interval to see if there are new vehicles?
If we are making a "list vehicles" call every few minutes we would need to reduce the interval for more important data calls.

I guess we could make a call every 24h, but seems a lot of work for very little benefit.

entity-category: done
entity-device-class: done
entity-disabled-by-default: done
Expand Down