Skip to content

Comments

Jewish Calendar: Implement diagnostics#145180

Merged
joostlek merged 3 commits intohome-assistant:devfrom
tsvi:jcal-diagnostics
May 19, 2025
Merged

Jewish Calendar: Implement diagnostics#145180
joostlek merged 3 commits intohome-assistant:devfrom
tsvi:jcal-diagnostics

Conversation

@tsvi
Copy link
Contributor

@tsvi tsvi commented May 19, 2025

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: Jewish Calendar quality scale #143763
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

epenet
epenet previously requested changes May 19, 2025
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think diagnostics require 100% coverage

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 19, 2025 07:37
@tsvi tsvi marked this pull request as ready for review May 19, 2025 16:38
@home-assistant home-assistant bot requested a review from epenet May 19, 2025 16:38
@tsvi tsvi mentioned this pull request May 19, 2025
19 tasks
@joostlek joostlek dismissed epenet’s stale review May 19, 2025 18:40

tests are there

@joostlek joostlek merged commit 1f6faaa into home-assistant:dev May 19, 2025
34 checks passed
@tsvi tsvi deleted the jcal-diagnostics branch May 19, 2025 19:10
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants