Jewish Calendar quality scale#143763
Conversation
tsvi
force-pushed
the
jcal-qs
branch
2 times, most recently
from
eb3d4e4 to
8e4361d
Compare
tsvi
force-pushed
the
jcal-qs
branch
2 times, most recently
from
35d91db to
3383d4d
Compare
joostlek
left a comment
joostlek
left a comment
There was a problem hiding this comment.
Can we get this PR in a state where it doesn't depend on other PRs so we can improve the state in those PRs?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Actually, I'm not sure we need the coordinator as part of the quality scale, so I think we can start looking at the various points and decide whether we're ready here. |
joostlek
left a comment
joostlek
left a comment
There was a problem hiding this comment.
Let's add the things we agree on to fix to todo and add the comments to the list and then we can merge and improve from there
| appropriate-polling: done | ||
| brands: done | ||
| common-modules: done | ||
| config-flow-test-coverage: done |
There was a problem hiding this comment.
Should we test that the option flow refreshes the entry?
There was a problem hiding this comment.
"Refreshes" meaning that the updated values are taken into consideration?
There was a problem hiding this comment.
| config-flow: done | ||
| dependency-transparency: done | ||
| docs-actions: done | ||
| docs-high-level-description: done |
There was a problem hiding this comment.
we can remove the
parenthesis here
There was a problem hiding this comment.
Done. See home-assistant/home-assistant.io#39998
| docs-configuration-parameters: done | ||
| docs-installation-parameters: done |
There was a problem hiding this comment.
There's a neat table you can use to format this, now everything is their own header
There was a problem hiding this comment.
Done. See home-assistant/home-assistant.io#39998
|
I think we're left with a single comment regarding the options flow test. @joostlek could you clarify what you meant by that? And if anything else is needed? |
2 participants
Proposed change
Depends on:
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: