Skip to content

Comments

Jewish Calendar: Make exception translatable#145376

Merged
edenhaus merged 1 commit intohome-assistant:devfrom
tsvi:jcal-trans-exceptions
May 21, 2025
Merged

Jewish Calendar: Make exception translatable#145376
edenhaus merged 1 commit intohome-assistant:devfrom
tsvi:jcal-trans-exceptions

Conversation

@tsvi
Copy link
Contributor

@tsvi tsvi commented May 21, 2025

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: Jewish Calendar quality scale #143763
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tsvi 👍

@edenhaus edenhaus merged commit bbd223a into home-assistant:dev May 21, 2025
33 of 34 checks passed
@NoRi2909
Copy link
Contributor

Google Translate, Deepl and MS Translate all turn this message into completely different meanings.

For a proper translation: "date" refers to a specific day when that "sunset event" happens?

@tsvi tsvi deleted the jcal-trans-exceptions branch May 21, 2025 15:44
@tsvi
Copy link
Contributor Author

tsvi commented May 21, 2025

Google Translate, Deepl and MS Translate all turn this message into completely different meanings.

For a proper translation: "date" refers to a specific day when that "sunset event" happens?

The meaning is that we can't get the sunset event for a specific date... Locations close to the poles can't have their sunset calculated.

@NoRi2909
Copy link
Contributor

OK, that makes sense. But then you should reword that message to something like:

"Sunset event cannot be calculated for that date and location"

Better use a few more words for these messages, otherwise many translations can become complete nonsense.

@tsvi tsvi mentioned this pull request May 21, 2025
19 tasks
@tsvi
Copy link
Contributor Author

tsvi commented May 21, 2025

@NoRi2909 you're right, I wasn't thinking about the contents 😄
Created #145400 to fix this

@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants