Skip to content

Comments

Quality fixes for Jewish Calendar#148689

Merged
joostlek merged 12 commits intohome-assistant:devfrom
tsvi:jcal-qual-fixes
Jul 14, 2025
Merged

Quality fixes for Jewish Calendar#148689
joostlek merged 12 commits intohome-assistant:devfrom
tsvi:jcal-qual-fixes

Conversation

@tsvi
Copy link
Contributor

@tsvi tsvi commented Jul 13, 2025

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: Jewish Calendar quality scale #143763
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@tsvi tsvi force-pushed the jcal-qual-fixes branch from 21b9fcd to 4c81218 Compare July 13, 2025 15:16
@tsvi tsvi mentioned this pull request Jul 13, 2025
19 tasks
@tsvi tsvi force-pushed the jcal-qual-fixes branch from 2082c57 to 7d6323a Compare July 13, 2025 21:44
@joostlek joostlek merged commit 9e022ad into home-assistant:dev Jul 14, 2025
34 checks passed
@tsvi tsvi deleted the jcal-qual-fixes branch July 14, 2025 16:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants