Skip to content

Fix possessive apostrophe errors in mqtt/strings.json#169576

Merged
jbouwh merged 3 commits intohome-assistant:devfrom
SeifEddineMezned:fix-mqtt-strings-grammar
Apr 30, 2026
Merged

Fix possessive apostrophe errors in mqtt/strings.json#169576
jbouwh merged 3 commits intohome-assistant:devfrom
SeifEddineMezned:fix-mqtt-strings-grammar

Conversation

@SeifEddineMezned
Copy link
Copy Markdown
Contributor

Proposed change

This PR fixes missing possessive apostrophes in user-facing strings in homeassistant/components/mqtt/strings.json.

  • Fixed "MQTT brokers certificate" -> "MQTT broker's certificate" (appeared twice)
  • Fixed "the brokers correct username and password" -> "the broker's correct username and password"

Type of change

  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: none
  • This PR is related to issue: none
  • Link to documentation pull request: none
  • Link to developer documentation pull request: none
  • Link to frontend pull request: none

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • I have followed the [perfect PR recommendations][perfect-pr]
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

To help with the load of incoming pull requests:

  • I have reviewed two other [open pull requests][prs] in this repository.

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @emontnemery, @jbouwh, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request corrects possessive apostrophes in the MQTT integration’s user-facing English strings (strings.json), improving the grammar shown in the config flow/reauth UI.

Changes:

  • Updated two occurrences of “MQTT brokers certificate” to “MQTT broker's certificate”.
  • Updated “the brokers correct username and password” to “the broker's correct username and password”.

Comment thread homeassistant/components/mqtt/strings.json Outdated
@home-assistant home-assistant Bot marked this pull request as draft April 30, 2026 21:36
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Comment thread homeassistant/components/mqtt/strings.json Outdated
Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 30, 2026 21:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates English user-facing MQTT integration strings to correct possessive apostrophes in certificate/authentication text shown in the config/reauth flows.

Changes:

  • Fixes two instances of “MQTT brokers certificate” to “MQTT broker's certificate”.
  • Fixes “the brokers correct username and password” to “the broker's correct username and password”.

Comment thread homeassistant/components/mqtt/strings.json
@SeifEddineMezned SeifEddineMezned marked this pull request as ready for review April 30, 2026 21:51
@home-assistant home-assistant Bot requested a review from jbouwh April 30, 2026 21:51
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thanks @SeifEddineMezned 👍

@jbouwh jbouwh added this to the 2026.5.0 milestone Apr 30, 2026
@SeifEddineMezned
Copy link
Copy Markdown
Contributor Author

@jbouwh thanks for your support

@jbouwh
Copy link
Copy Markdown
Contributor

jbouwh commented Apr 30, 2026

Thanks to you!

@jbouwh jbouwh merged commit 1828931 into home-assistant:dev Apr 30, 2026
44 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants