Add exception for dynamic devices quality scale rule#2662
Draft
joostlek wants to merge 1 commit into
Draft
Conversation
Contributor
|
I'm not sure of the wording either - but I approve 😄 |
19 tasks
Contributor
|
We discussed this in the core meeting, and the conclusion is that it's OK to reload the integration when detecting a rare occurrence, but not OK to not detect it at all. This means the third example (Renault) in the PR description is not valid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Okay so after this rule has been added, we have seen a couple of integrations where we think its not reasonable to enforce this rule. I am not 100% yet on the wording so I would love some feedback on this one. To give some examples and reasoning behind them, I will add some examples so we can also discuss those.
Type of change
Checklist
Additional information