Finalise fixes to photo uploader workflow (separate dialogs, review map, edge cases & resiliency)#733
Merged
spwoodcock merged 20 commits intohotosm:devfrom Mar 17, 2026
Conversation
7 tasks
Collaborator
Author
|
Before:
After
I am adding automated tests for the following manual tests
|
1f78a46 to
76cb50c
Compare
Member
|
Looking good! |
fix hotosm#701 Assisted by: Opus 4.6 LLM
Assisted by: Opus 4.6 + Codex 5.3 for verification
Assisted by: Codex 5.3 for finding issues
Member
|
I think we are good to go! The tests are failing because of issues with forked repos I believe - they all pass locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Fixes #713 & Fixes #715
edit by @spwoodcock: Also fixes #701 fixes #719 fixes #720 fixes #504
Describe this PR
TBA
Screenshots
Alternative Approaches Considered
TBA
Did you attempt any other approaches that are not documented in code?
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?