Fix issue #352 #523
Merged
Fix issue #352 #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We tell students to extensively use const, but the spans demo would have allowed changing values in the original containers. Fix hsf-training#352
The example was mentioned to be difficult to read. Fix hsf-training#352.
sponce
approved these changes
Aug 21, 2024
Co-authored-by: Sebastien Ponce <[email protected]>
- Slightly reword a few sentences. - Fit bullet points in a single line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the next advanced course, I went through the list of suggestions in #352, and implemented most of them.
A few of these were not relevant enough on second thought, so I propose to close #352 after this PR.
Fix #352.