Fix _load_repository_from_gcs
#76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was with the `join` call over a `pathlib.Path` object, so the `pathlib.Path` cast was missing on the `file_split[0::-1]` variable
alvarobartt
added a commit
that referenced
this pull request
Aug 5, 2024
Ideally the `pip install` command shouldn't be required as it's installed already within the `integration-test-pytorch:gpu` image, but if adding it, to ensure consistency we should also include the recently included `google` extra that comes with `google-cloud-storage`; otherwise the tests within #76 will fail
philschmid
approved these changes
Aug 5, 2024
alvarobartt
added a commit
that referenced
this pull request
Aug 7, 2024
* Fix formatting in `setup.py` * Add missing trove classifiers * Add missing description * Add missing `google-cloud-storage` as `google` extra * Update `Dockerfile` indent size and `google-cloud-storage` installation - Align indent size with `apt-get install` even if those are just args - Align flag usage notation from `-U` to `--upgrade` i.e. using full name instead of shortened one for readability - Install `google-cloud-storage` from `google` extra instead (`google` extra was included recently as otherwise the installations from the wheel not relying on this Dockerfile would fail with an ImportError on `google-cloud-storage` when either deploying from Vertex AI or setting the `AIP_STORAGE_URI` env var) * Add newline at the end of `setup.cfg` * Update `.github/workflows/unit-test.yaml` to install `google` extras too Ideally the `pip install` command shouldn't be required as it's installed already within the `integration-test-pytorch:gpu` image, but if adding it, to ensure consistency we should also include the recently included `google` extra that comes with `google-cloud-storage`; otherwise the tests within #76 will fail
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
_load_repository_from_gcsmethod, as there was an issue with thejoincall over apathlib.Pathobject, so thepathlib.Pathcast was missing on thefile_split[0::-1]variable; as well as joining thetarget_dirwithin the local file path were the artifacts were being downloaded to.From now on, in order to download and use artifacts from Google Cloud Storage, one will need to set the
AIP_STORAGE_URIenvironment variable (automatically exposed by Vertex AI when deploying from a bucket).Thanks Genquan Duan and Changyu Zhu from Google for the report! 🤗