Skip to content

Fix _load_repository_from_gcs #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/huggingface_inference_toolkit/vertex_ai_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ def _load_repository_from_gcs(artifact_uri: str, target_dir: Union[str, Path] =
from google.cloud import storage

logger.info(f"Loading model artifacts from {artifact_uri} to {target_dir}")
target_dir = Path(target_dir)
if isinstance(target_dir, str):
target_dir = Path(target_dir)

if artifact_uri.startswith(GCS_URI_PREFIX):
matches = re.match(f"{GCS_URI_PREFIX}(.*?)/(.*)", artifact_uri)
Expand All @@ -31,9 +32,9 @@ def _load_repository_from_gcs(artifact_uri: str, target_dir: Union[str, Path] =
else name_without_prefix
)
file_split = name_without_prefix.split("/")
directory = target_dir.join(file_split[0:-1])
directory = target_dir / Path(*file_split[0:-1])
directory.mkdir(parents=True, exist_ok=True)
if name_without_prefix and not name_without_prefix.endswith("/"):
blob.download_to_filename(name_without_prefix)
blob.download_to_filename(target_dir / name_without_prefix)

return str(target_dir.absolute())
24 changes: 24 additions & 0 deletions tests/unit/test_vertex_ai_utils.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
from pathlib import Path

from huggingface_inference_toolkit.vertex_ai_utils import _load_repository_from_gcs


def test__load_repository_from_gcs():
"""Tests the `_load_repository_from_gcs` function against a public artifact URI.

References:
- https://cloud.google.com/storage/docs/public-datasets/era5
- https://console.cloud.google.com/storage/browser/gcp-public-data-arco-era5/raw/date-variable-static/2021/12/31/soil_type?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))
"""

public_artifact_uri = (
"gs://gcp-public-data-arco-era5/raw/date-variable-static/2021/12/31/soil_type"
)
target_dir = Path.cwd() / "target"
target_dir_path = _load_repository_from_gcs(
artifact_uri=public_artifact_uri, target_dir=target_dir
)

assert target_dir == Path(target_dir_path)
assert Path(target_dir_path).exists()
assert (Path(target_dir_path) / "static.nc").exists()
Loading