refactor: chapter control progress bar bindings

[United600]

No description provided.

[Copilot]

Pull Request Overview

This PR modernizes the XAML data binding in the ChapterProgressBar control by migrating from runtime Binding to compile-time x:Bind syntax, which provides better performance and compile-time type checking.

• Converted all four property bindings (Width, Maximum, Minimum, Value) from Binding to x:Bind with explicit Mode=OneWay

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[United600]

Instead of spamming Mode=OneWay I could have just done:

<DataTemplate
    x:Key="ItemTemplate"
    x:DataType="viewModels:ChapterViewModel"
    x:DefaultBindMode="OneWay">

[huynhsontung]

Ooh I don't know about that. I think explicitly state binding mode still has its merits. I rely on the fact that x:Bind defaults to OneTime quite often. I don't know if implicitly changing the binding mode is a good idea here.

[United600]

Yeah, it still seems useful in certain situations (like in this one).

[huynhsontung]

If I remember correctly, I used Bindings here for a reason. When I last tested this, there were some edge cases where ItemRepeater and x:Bind don't play nice together. Did you encounter any issues in your testing?

[United600]

If I remember correctly, I used Bindings here for a reason. When I last tested this, there were some edge cases where ItemRepeater and x:Bind don't play nice together. Did you encounter any issues in your testing?

No, but I haven't tested it extensively. Just a couple of files with chapters. But now that I know you've run into issues, I'll test it with a few more.

[United600]

If I remember correctly, I used Bindings here for a reason. When I last tested this, there were some edge cases where ItemRepeater and x:Bind don't play nice together. Did you encounter any issues in your testing?

Can confirm. Works correctly for the first file in a session, but subsequent files incorrectly applies the Value to some chapters.

The ItemsRepeater also isn't properly clearing the list. While replacing it with an ItemsControl would resolve both this issue and the previous one, it introduces a regression (increasing the Spacing will cause value misalignment in some files).

<ItemsControl ItemTemplate="{StaticResource ItemTemplate}" ItemsSource="{x:Bind ProgressItems}">
    <ItemsControl.ItemsPanel>
        <ItemsPanelTemplate>
            <StackPanel Orientation="Horizontal" Spacing="1" />
        </ItemsPanelTemplate>
    </ItemsControl.ItemsPanel>
</ItemsControl>