Skip to content

refactor: chapter control progress bar bindings #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
United600 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: chapter control progress bar bindings #717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Screenbox/Controls/ChapterProgressBar.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@

<DataTemplate x:Key="ItemTemplate" x:DataType="viewModels:ChapterViewModel">
Copy link
Collaborator Author

@United600 United600 Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of spamming Mode=OneWay I could have just done:

<DataTemplate
    x:Key="ItemTemplate"
    x:DataType="viewModels:ChapterViewModel"
    x:DefaultBindMode="OneWay">

Copy link
Owner

@huynhsontung huynhsontung Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh I don't know about that. I think explicitly state binding mode still has its merits. I rely on the fact that x:Bind defaults to OneTime quite often. I don't know if implicitly changing the binding mode is a good idea here.

Copy link
Collaborator Author

@United600 United600 Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it still seems useful in certain situations (like in this one).

<muxc:ProgressBar
Width="{Binding Width}"
Maximum="{Binding Maximum}"
Minimum="{Binding Minimum}"
Width="{x:Bind Width, Mode=OneWay}"
Maximum="{x:Bind Maximum, Mode=OneWay}"
Minimum="{x:Bind Minimum, Mode=OneWay}"
Style="{StaticResource NoAnimationProgressBarStyle}"
Value="{Binding Value}" />
Value="{x:Bind Value, Mode=OneWay}" />
</DataTemplate>

<muxc:StackLayout
Expand Down