Safe integration for mintHypercert() #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Merkle trees had slight differences in their generic type. All functions in the allowlist utils return the generic parameter [string, bigint]
Since it's only used in one place we can inline.
One of the test cases experiences temporal coupling with the getConnected() method. I tried to move the method call down to where it is used and that broke the test.
Without this patch the caller is only able to mint a Hypercert with their connected browser wallet.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This was referenced Mar 11, 2025
Jipperism
approved these changes
Mar 11, 2025
Yep, good point. We should harmonise this at some point. @bitbeckers and I decided on the quicker implementation to get this shipped sooner rather than later. Otherwise I would've spent some time to clean up the function, split it out probably using a strategy pattern to have a clean separation between the EOA and multisig cases. At any rate, |
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Safe support for minting a new Hypercert.
The way to switch the SDK over to propose a transaction to the Safe app is to add
safeAddressto theoverridesobject.You can see a Safe transaction created by the SDK here.