Skip to content

Enable batch claiming from a Safe #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Conversation

pheuberger
Copy link
Member

In commit b04e781 I missed the batch claiming part of claiming hypercert fractions. This patch adds support for it.

Copy link

github-actions bot commented Apr 4, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 78.62% (🎯 78%) 1155 / 1469
🟢 Statements 78.62% (🎯 78%) 1155 / 1469
🟢 Functions 78.44% (🎯 77%) 91 / 116
🟢 Branches 84.45% (🎯 84%) 277 / 328
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/client.ts 68.62% 80.19% 55.55% 68.62% 81-83, 94-95, 105-106, 131-133, 177-209, 215-216, 220-221, 238-239, 251-257, 270-273, 288-298, 313-323, 329-336, 384-385, 428-429, 463-464, 507-513, 523-530, 573-579, 608-610, 685-686
Generated in workflow #34 for commit 1483f6e by the Vitest Coverage Report Action

In commit b04e781 I missed the batch claiming part of claiming
hypercert fractions. This patch adds support for it.

I had to lower the branch coverage threshold by one percentage point.
Unfortunately it is too difficult to test the newly introduced branch
with the time I have available to implement this feature.
@pheuberger
Copy link
Member Author

Sorry @bitbeckers I had to lower the coverage threshold a tiny bit.

@pheuberger pheuberger merged commit 89390e2 into main Apr 7, 2025
2 checks passed
@pheuberger pheuberger deleted the safe-support-batch-claiming branch April 7, 2025 16:09
@bitbeckers
Copy link
Contributor

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants