Skip to content

Make fee token configurable#22

Open
yorhodes wants to merge 7 commits intomainfrom
yorhodes/fee-token
Open

Make fee token configurable#22
yorhodes wants to merge 7 commits intomainfrom
yorhodes/fee-token

Conversation

@yorhodes
Copy link
Copy Markdown
Member

@yorhodes yorhodes commented Jun 17, 2025

scarb run starknet will generate with STRK on starknet
scarb run paradex will generate with USDC on paradex

Copy link
Copy Markdown

@aroralanuk aroralanuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It'll be nice to specify network and token so the script can validate like

scrab build starknetsepolia STRK or
scrab build paradex USDC


[scripts]
starknet = "FEE_TOKEN=0x04718f5a0fc34cc1af16a1cdee98ffb20c31f5cd61d6ab07201858f4287c938d ./feeToken.sh"
paradex = "FEE_TOKEN=0x049d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7 ./feeToken.sh"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is just for testnets?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have accidentally copied the wrong address for paradex

Copy link
Copy Markdown

@aroralanuk aroralanuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking the earlier comment as nit and approving this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants