Refactor makefile and gh actions #1049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandenburger
added
cleanup
mbrandenburger
force-pushed
the
itest-restruct
branch
2 times, most recently
from
a33cb84 to
83e0585
Compare
Member
Author
|
TODO: |
mbrandenburger
force-pushed
the
itest-restruct
branch
from
6db59bf to
a76024f
Compare
Member
Author
As discussed, this PR changes NWO to place the generated |
arner
approved these changes
Oct 7, 2025
Makefile
Outdated
| cd ./integration/$(firstword $(subst -, ,$*))/$(subst $(firstword $(subst -, ,$*))-,,$*); \ | ||
| ginkgo $(GINKGO_TEST_OPTS) . | ||
|
|
||
| #cd ./integration/$(word 1,$(subst -, ,$(@:integration-tests-%=%)))/$(word 2,$(subst -, ,$(@:integration-tests-%=%))); \ |
Contributor
There was a problem hiding this comment.
can this be removed or explained?
Member
Author
There was a problem hiding this comment.
good catch! removed
- cleanup / update gh actions - cleanup makefile - move some integration tests to adress changes in makefile Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
mbrandenburger
force-pushed
the
itest-restruct
branch
from
a76024f to
52d4ceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmdfolder now inout/cmdfor each integration test.