test: improve coverage for token/token package (#1348)

[nishantbkl3345-ship-it]

Summary

This PR improves unit test coverage for the token/token package as part of #1348.

What’s included

• added a new token_test.go file to cover logic in token.go
• added a few focused tests in quantity_test.go for missing paths (e.g. ToBigInt, type mismatch cases, and edge scenarios)
• all tests pass locally

Coverage

• package coverage is now ~93%

Notes

I avoided duplicating existing tests and focused only on uncovered or weakly covered areas, mainly in token.go and a few edge cases in quantity.go.

Let me know if you’d like me to adjust or expand any tests.

[Copilot]

Pull request overview

This PR increases unit test coverage for the token/token package (targeting ~93% coverage) by adding missing tests for core token structs and quantity edge cases.

Changes:

• Added a new token_test.go covering ID, LedgerToken, and token collection helpers (Sum, ByType, Count, At).
• Expanded quantity_test.go to cover ToBigInt, type-mismatch panics, non-64 precision paths, and negative decimal input handling.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
token/token/token_test.go	New unit tests for token identifiers, ledger token equality, and issued/unspent token collection helpers.
token/token/quantity_test.go	Additional unit tests covering ToBigInt, panic behavior on type mismatches, BigQuantity path in UInt64ToQuantity, and negative decimal parsing.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The comment "fresh instance after mutation" is misleading here: the preceding Add/Sub/Cmp calls are expected to panic before mutating big128, so there is no mutation to recover from. Consider rewording or removing the comment to reflect what’s actually happening (e.g., "fresh instance" without implying mutation).

Suggested change

	big128 = token.NewZeroQuantity(128) // fresh instance after mutation
	big128 = token.NewZeroQuantity(128) // fresh instance

[nishantbkl3345-ship-it]

Opened a PR for this here: #1478

[adecaro]

Hi @nishantbkl3345-ship-it , please, rebase and check the linter errors. You can run the linters with make lint and make checks (run both). The makefile contains also entries to install the tools.

Thanks 🙏

[adecaro]

Hi @nishantbkl3345-ship-it , thanks for submitting this. I'll review ASAP.

[adecaro]

LGTM

[adecaro]

Hi @nishantbkl3345-ship-it , please, check again the PR. There are linting issues. We have upgraded golangci-lint version. Thanks 🙏

[nishantbkl3345-ship-it]

I checked it again with the updated lint setup and pushed a follow-up fix.

I cleaned up the issues in quantity.go and updated the quantity tests to match the current behavior. All tests and lint checks pass locally now.

[adecaro]

Hi @nishantbkl3345-ship-it , please, fix the conflicts. Thanks 🙏

[adecaro]

@nishantbkl3345-ship-it , there is something strange in the PR. There are way too many files changed. Please, have a second look.

[adecaro]

Please, double check the PR.