Retry npm commands on TS sanity plugin #1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
OriolMunoz-da
force-pushed
the
oriol/retry-ts-sanity
branch
from
fced6b2 to
9f02495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes since the PR in the private repo
(copied description:)
What I found:
So this seems to be some issue with node, or some native library that we use, or who knows. I'm hoping that a retry would fix the issue, but of course I can't know that because it's not even reproducible 🤷
Some online docs pointed at maybe node_modules being corrupt somehow, but slapping an npm rebuild or whatever doesn't seem great either... why can't npm just work...