Skip to content

Retry npm commands on TS sanity plugin #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OriolMunoz-da merged 1 commit into from
Jun 6, 2025
Merged

Retry npm commands on TS sanity plugin #1026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ...g/lfdecentralizedtrust/splice/integration/plugins/TokenStandardCliSanityCheckPlugin.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ class TokenStandardCliSanityCheckPlugin(
token: String,
participantPort: Int,
extraArgs: Seq[String],
retries: Int = 3,
)(implicit
tc: TraceContext
): String = {
Expand Down Expand Up @@ -159,8 +160,16 @@ class TokenStandardCliSanityCheckPlugin(
if (exitCodeTry.toOption.exists(_ != 0) || exitCodeTry.isFailure) {
logger.error(s"Failed to run $args: $exitCodeTry. Dumping output.")(TraceContext.empty)
readLines.foreach(logger.error(_)(TraceContext.empty))
// sometimes readlines is empty...?
throw new RuntimeException(s"$args failed: ${readLines}")
if (retries > 0) {
// node commands sometimes give no logs whatsoever, and sometimes they segfault and dump a native stack trace,
// so retrying seems like the best solution.
// If the cause of the error is not-node-related, it should fail quick enough that it won't slow down tests too much.
logger.info(s"Retrying command $args")
runCommand(command, partyId, token, participantPort, extraArgs, retries - 1)
} else {
// sometimes readlines is empty...?
throw new RuntimeException(s"$args failed: ${readLines}")
}
}
val result = readLines
.dropWhile(line => !line.startsWith("[") && !line.startsWith("{")) // remove npm noise
Expand Down
Loading