migrate to Java 21 #1033
Merged
migrate to Java 21 #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project’s Java runtime from version 17 to 21 across Nix environments and Docker images, while adding a deprecation annotation and modernizing URI usage in tests.
- Bump OpenJDK in Nix shell and overlays to version 21
- Update Docker base images to Eclipse Temurin 21
- Mark a deprecated MemoryMXBean method and switch from URL to URI in tests
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| nix/shell.nix | Updated OpenJDK from 17 to 21 |
| nix/overlays.nix | Pointed jre overrides to OpenJDK 21 |
| cluster/images/splice-app/Dockerfile | Changed base image to eclipse-temurin:21 |
| cluster/images/canton/Dockerfile | Changed base image to eclipse-temurin:21 |
| canton/.../MemoryCheck.scala | Annotated deprecated getObjectPendingFinalizationCount |
| WalletAuth0FrontendIntegrationTest.scala | Imported java.net.URI and converted to URL |
| AnsAuth0FrontendIntegrationTest.scala | Imported java.net.URI and converted to URL |
Comments suppressed due to low confidence (2)
cluster/images/splice-app/Dockerfile:40
- Verify that the
eclipse-temurin:21-jdk-nobletag exists. If it does not, update to a valid Eclipse Temurin 21 image (e.g.,21-jdk-jammyor21-jdk).
FROM eclipse-temurin:21-jdk-noble
cluster/images/canton/Dockerfile:37
- Ensure the
eclipse-temurin:21-jdk-noblebase image tag is valid. Consider using an officially supported tag such as21-jdk-jammyor21-jdk.
FROM eclipse-temurin:21-jdk-noble
stephencompall-DA
force-pushed
the
s11/895-java-21
branch
from
a4ae179 to
5ccdd0f
Compare
nicu-da
approved these changes
Jun 10, 2025
Contributor
nicu-da
left a comment
nicu-da
left a comment
There was a problem hiding this comment.
Nice, thanks!
We probs want to add a release note for this as well!
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
- jammy will be removed for Java 22 releases; noble has been default for almost a year Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
stephencompall-DA
force-pushed
the
s11/895-java-21
branch
from
5495494 to
d7ada58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #895.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines