enable cimain&ciupgrade on splice #1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
isegall-da
force-pushed
the
isegall/cimain-ciperiodic
branch
from
54bcb56 to
e79706c
Compare
moritzkiefer-da
approved these changes
Jun 6, 2025
Contributor
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
looks plausible, we don't need ciperiodic because that has a periodic trigger instead of a per commit trigger right?
stephencompall-DA
approved these changes
Jun 6, 2025
| secrets: inherit | ||
| with: | ||
| workflow: deploy_cimain | ||
| sha: ${{ github.sha }} |
Contributor
There was a problem hiding this comment.
This defaults to false, which seems wrong.
Suggested change
| sha: ${{ github.sha }} | |
| sha: ${{ github.sha }} | |
| public_splice: ${{ github.repository == 'hyperledger-labs/splice' }} |
Contributor
Author
There was a problem hiding this comment.
Good catch, we removed it completely from canton-network-internal, but not from here. I'll just remove it.
| secrets: inherit | ||
| with: | ||
| workflow: deploy_ciupgrade | ||
| sha: ${{ github.sha }} |
Contributor
There was a problem hiding this comment.
Suggested change
| sha: ${{ github.sha }} | |
| sha: ${{ github.sha }} | |
| public_splice: ${{ github.repository == 'hyperledger-labs/splice' }} |
Contributor
Author
Correct |
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
isegall-da
force-pushed
the
isegall/cimain-ciperiodic
branch
from
78d8b08 to
63c2f7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure that this is all it takes, now that the submodule in
cn-internalis spliceFixes #1039
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines