Skip to content

enable cimain&ciupgrade on splice #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isegall-da merged 3 commits into from
Jun 7, 2025
Merged

enable cimain&ciupgrade on splice #1038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e79706c
[static] enable cimain&ciupgrade on splice
isegall-da Jun 6, 2025
40db249
public_splice
isegall-da Jun 6, 2025
63c2f7a
[static]
isegall-da Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/cimain.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Deploy CIMain
on:
push:
branches:
- 'main'

jobs:
trigger_cimain:
uses: ./.github/workflows/cluster_tests.yml
secrets: inherit
with:
workflow: deploy_cimain
sha: ${{ github.sha }}
Copy link
Contributor

@stephencompall-DA stephencompall-DA Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This defaults to false, which seems wrong.

Suggested change
sha: ${{ github.sha }}
sha: ${{ github.sha }}
public_splice: ${{ github.repository == 'hyperledger-labs/splice' }}

Copy link
Contributor Author

@isegall-da isegall-da Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, we removed it completely from canton-network-internal, but not from here. I'll just remove it.

13 changes: 13 additions & 0 deletions .github/workflows/ciupgrade.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Deploy CIUpgrade
on:
push:
branches:
- 'main'

jobs:
trigger_ciupgrade:
uses: ./.github/workflows/cluster_tests.yml
secrets: inherit
with:
workflow: deploy_ciupgrade
sha: ${{ github.sha }}
Copy link
Contributor

@stephencompall-DA stephencompall-DA Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha: ${{ github.sha }}
sha: ${{ github.sha }}
public_splice: ${{ github.repository == 'hyperledger-labs/splice' }}

5 changes: 1 addition & 4 deletions .github/workflows/cluster_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ on:
sha:
type: string
required: true
public_splice:
type: boolean
required: false

outputs:
result:
Expand Down Expand Up @@ -42,5 +39,5 @@ jobs:
run: |
set -euo pipefail
result=$(curl -sSfL -H "Authorization: Bearer ${{ steps.auth.outputs.id_token }}" \
"${{ secrets.CLUSTER_TEST_INVOKER_URL }}?workflow=${{ inputs.workflow }}&splice-git-ref=${{ inputs.sha }}&public-splice=${{ inputs.public_splice }}")
"${{ secrets.CLUSTER_TEST_INVOKER_URL }}?workflow=${{ inputs.workflow }}&splice-git-ref=${{ inputs.sha }}")
echo "result=$result" >> "$GITHUB_OUTPUT"
2 changes: 0 additions & 2 deletions .github/workflows/pr_cluster_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ jobs:
with:
workflow: cluster_test
sha: ${{ needs.get_head.outputs.sha }}
public_splice: ${{ github.repository == 'hyperledger-labs/splice' }}

result:
runs-on: self-hosted-docker-tiny
Expand All @@ -54,7 +53,6 @@ jobs:
with:
workflow: hdm_test
sha: ${{ needs.get_head.outputs.sha }}
public_splice: ${{ github.repository == 'hyperledger-labs/splice' }}

result_hdm:
runs-on: self-hosted-docker-tiny
Expand Down
Loading