Skip to content

Conversation

@isegall-da
Copy link
Contributor

@isegall-da isegall-da commented Jun 7, 2025

Was used at some point during the transition period when we had clusters in both.

Originally I thought I'd keep it around (just update to Splice) in order to support operator deployments directly from Splice, but since we're not actively testing it, I doubt it will remain working for long (if it even is currently). I propose we drop it, and consider adding back if there's a great need for it.

[ Might require backporting to 0.3.21 for HDM tests, I'll look at its usage more carefully on Monday, i.e. whether it's ever invoked from the base branch in HDM tests ]

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@isegall-da
Copy link
Contributor Author

Might require backporting I modified it to be backward compatible, so that in canton-network-internal we can continue setting canton-network-internal there, and that will just be silently ignored in the cncluster script. In #1062 we will remove support for that, and stop passing that argument.

Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
@isegall-da isegall-da merged commit a6f7631 into main Jun 10, 2025
41 checks passed
@isegall-da isegall-da deleted the isegall/flux-repo branch June 10, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants